Fix for pipeline id #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the PR is missing the addition of the global variable of type The program should do something like this: |
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 5. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v5) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Try to handle pna_main_input_metadata_t fields better * Add support for parser errors in tc backend --------- Co-authored-by: Mouse <[email protected]>
* Add aligned new / delete libgc overloads. Also cleaned some old stuff that is not relevant in year 2024 * Add nothrow overrides * A bit more clear realignment
* Try to speed up the CI build process * Update install_fedora_deps.sh * Update ci-test.yml
…4463) * Bump protobuf version. Fix some missed dependencies here and there * Grab abseil using FetchContent * Disable unity builds for Abseil * Try to bumpprotobuf version in bazel * Pull abseil * Address review comments * Fix UB in json parser that remained from GMP times * Ensure sanitizer options are propagated down to dependencies (protobuf, abseil, etc.) * Some readme refines * See if we can workaround ubsan + int128 bug * Clarify ubsan issue workaround * Fix typo in README.md Co-authored-by: Vladimír Štill <[email protected]> --------- Co-authored-by: Vladimír Štill <[email protected]>
|
@vbnogueira . This PR is still in progress. Implementation is not yet completed. Once completed, I will let you know for your review |
Sosutha
force-pushed
the
p4tc_pipeline_id_fix
branch
from
0aabb19 to
5804d33
Compare
|
@vbnogueira Please review now |
@Sosutha LGTM |
…iables. (p4lang#4398) * [P4Testgen] Implement a library for common control-plane symbolic variables. * Review comments. * Use std::tie.
* Make use of abseil flat_hash_map * Preallocate at least 16 slots * Use better hash * Do not do lookup twice to get final result * Clarify comment * Clarify docstring Co-authored-by: Glen Gibb <[email protected]> * Link abseil privately to IR * Clarify iterator usage * Refined `finalResult` semantics` --------- Co-authored-by: Glen Gibb <[email protected]>
* Try to clean up the Protobuf includes. * Review comments.
* Removed pipeline id from introspection.json for tc backend * Updated the testcases outputs
Sosutha
force-pushed
the
p4tc_pipeline_id_fix
branch
from
5804d33 to
524ded6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/p4tc-dev/p4tc-e2e/issues/49