Added default action code for tc backend #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhsmt @vbnogueira Please review |
Sosutha
force-pushed
the
p4tc_fix_for_default_miss
branch
from
33d6fdf to
9b6b137
Compare
psivanup
approved these changes
Mar 21, 2024
backends/tc/ebpfCodeGen.cpp
Outdated
| auto actionNameStr = defaultActionName.c_str(); | ||
| for (long unsigned int i = 0; i < defaultActionName.size(); i++) { | ||
| if (actionNameStr[i] == '/') { | ||
| defaultActionName = |
There was a problem hiding this comment.
will cstring's find/ findlast solve the purpose?
There was a problem hiding this comment.
Both these functions returns pointer to the character in the string, but not actual position, hence they cannot be used
There was a problem hiding this comment.
ref: test_backend.cpp
fieldString = fieldString.substr(fieldString.find('.') - fieldString.begin() + 1);
Sosutha
force-pushed
the
p4tc_fix_for_default_miss
branch
from
9b6b137 to
9c81206
Compare
usha1830
approved these changes
Mar 26, 2024
| if (value->is_default_miss_act) | ||
| { | ||
| /* send_to_port(p4tc_filter_fields.ipv4_tbl_1_next_hop_vport) */ | ||
| compiler_meta__->drop = false; |
There was a problem hiding this comment.
this statement and the other common statements in if/else can be moved outside if
There was a problem hiding this comment.
Moving the common statements out of if/else requires more common code from ebpf to be replicated. Hence implemented like this
* Added default action code in control block for tc backend * Updated testcase outputs
Sosutha
force-pushed
the
p4tc_fix_for_default_miss
branch
from
9c81206 to
a6f5d3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added default action code in control block for tc backend
Updated testcase outputs
#4 (comment)