-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose rollup transaction statuses over sequencer RPC #1243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neysofu
force-pushed
the
filippo/track-l2-txs
branch
from
December 21, 2023 18:57
5d68a6b
to
8e48117
Compare
Codecov ReportAttention:
Additional details and impacted files
|
neysofu
force-pushed
the
filippo/track-l2-txs
branch
from
January 8, 2024 11:52
2a18670
to
620272b
Compare
neysofu
changed the title
WIP: Expose rollup transaction statuses over sequencer RPC
Expose rollup transaction statuses over sequencer RPC
Jan 9, 2024
Signed-off-by: Filippo Costa <[email protected]>
Signed-off-by: Filippo Costa <[email protected]>
Signed-off-by: Filippo Costa <[email protected]>
Signed-off-by: Filippo Costa <[email protected]>
Signed-off-by: Filippo Costa <[email protected]>
Signed-off-by: Filippo Costa <[email protected]>
neysofu
force-pushed
the
filippo/track-l2-txs
branch
from
January 9, 2024 22:48
e067dbe
to
9f5c667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces transaction status monitoring via JSON-RPC to
sov-sequencer
.Transactions can have one of four statuses:
Unknown
.Submitted
, i.e. accepted into the mempool.Published
, i.e. published to the DA as part of a batch.Finalized
, i.e. part of a finalized DA block.The core status tracking logic is inside
tx_status.rs
, although the changes tolib.rs
andbatch_builder
.rs are also meaningful.I've also extended the client logic in
util.rs
to support the new subscription endpoints.TODO
Finalized block notifications. Blocked by #1294.
Testing
One integration test over JSON-RPC and two unit tests. Resource deallocation after subscriptions are dropped is also tested.