Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/readd ciab and testbed #291

Merged
merged 7 commits into from
Jan 23, 2025
Merged

Fix/readd ciab and testbed #291

merged 7 commits into from
Jan 23, 2025

Conversation

garloff
Copy link
Member

@garloff garloff commented Jan 23, 2025 •
edited by maxwolfs
Loading

fixes #287

@garloff
Include CiaB and testbed docs again.
e343a27 
They moved, see issue #287.

Signed-off-by: Kurt Garloff <[email protected]>
@garloff
Need prettier.
17b7fe8 
Signed-off-by: Kurt Garloff <[email protected]>
@garloff
It's not a subdirectory but testbed.mdx
9e58e29 
Signed-off-by: Kurt Garloff <[email protected]>
@garloff
Add CiaB and Testbed to IaaS Deployments Examples sidebar.
b7164de 
Signed-off-by: Kurt Garloff <[email protected]>
@garloff
Need to link index
a9608f3 
Signed-off-by: Kurt Garloff <[email protected]>
@garloff
Next attempt.
49196c8 
Signed-off-by: Kurt Garloff <[email protected]>
@garloff garloff requested review from berendt and maxwolfs January 23, 2025 10:59
@garloff
Copy link
Member Author

garloff commented Jan 23, 2025 •
edited by maxwolfs
Loading

Can be seen live on https://docs-staging.scs.community/

maxwolfs
maxwolfs approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@maxwolfs maxwolfs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Preview deployemt has a 's' typo, but it works! Place within docs is correct imo and fixes #287.

@garloff
Copy link
Member Author

garloff commented Jan 23, 2025

Thanks, @maxwolfs. I was trying to understand and spot (and fix) the 's' typo, but I failed to see what you mean.
Anyway, merging now, improving later.

@garloff garloff merged commit 15e4107 into main Jan 23, 2025
5 checks passed
@garloff garloff deleted the fix/readd-ciab-and-testbed branch January 23, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwolfs maxwolfs maxwolfs approved these changes

@berendt berendt Awaiting requested review from berendt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CiaB documentation vanished from docs.scs.community
2 participants
@garloff @maxwolfs