Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better avoidance of a force-dark function #195

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Sp3EdeR
Copy link
Owner

@Sp3EdeR Sp3EdeR commented Oct 10, 2024

Many browsers have a forced dark mode feature for websites that only support light mode The force dark mode function should be disabled for this website, as it supports mode switching. This feature helps browsers detect that the website supports dark-mode and disable force dark.

Notes for reviewer:

Many browsers have a forced dark mode feature for websites that only support light mode
The force dark mode function should be disabled for this website, as it supports mode switching.
This feature helps browsers detect that the website supports dark-mode and disable force dark.
@Sp3EdeR Sp3EdeR requested a review from nbali October 10, 2024 11:17
@Sp3EdeR Sp3EdeR enabled auto-merge (rebase) October 10, 2024 11:17
Copy link

github-actions bot commented Oct 10, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-10 15:01 UTC

Copy link
Collaborator

@nbali nbali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Sp3EdeR Sp3EdeR merged commit 4018f07 into master Oct 10, 2024
4 checks passed
@Sp3EdeR Sp3EdeR deleted the bugfix/better-forcedark-avoidance branch October 10, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants