Add power_generation sensor #105
Conversation
15-draft.json
Outdated
| "type": "number" | ||
| }, | ||
| "unit": { | ||
| "description": "The unit of the sensor value. You should always define the unit though if the sensor is a flag of a boolean type then you can of course omit it.", |
There was a problem hiding this comment.
The description does seem a bit off? How can the sensor be of boolean type? Also since it is a required field one can't omit it.
There was a problem hiding this comment.
Actually, I copy&pasted from power consumption and did not have a close enough look at it.
So anything that you might request here is probably also wrong at power_consumption :)
There was a problem hiding this comment.
I have remove the misleading part of the description in 961e696.
There was a problem hiding this comment.
Thanks we'll fix this for the other sensor.
|
@rnestler Please review again. |
| "W", | ||
| "VA" |
There was a problem hiding this comment.
We removed mW since it doesn't make sense to have it, since 1e-3W are equal to 1mW. VA on the other hand has a slightly different meaning since it is used for Apparent power.
There was a problem hiding this comment.
We'll remove it from other sensors as well.
EDIT: We have a solar panel near our space. So far, spaceapi only allowed for
power_consumption, butpower_generationwas still missing.This PR intends to change that.
An example can be found at: https://spaceapi.ccc-p.org/