-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TUI with separation of input and output #34
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, when I have a minute I'll check this across a few platforms to make sure everything is still working given the dependency updates. Thanks a lot for all the work you've done here!
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could improve readability if we reduce the nesting here somehow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I combined some conditions from nested if statements and moved event handling into a separate function to help with this.
Feel free to let me know if there is anything I can do to help move things forward. I understand that the dependency updates may require additional testing so if there is a way that I can help with that, I am happy to contribute to make the process smoother. |
Resolves #10