Fix issue for pull request

SparseLinearAlgebra · Jul 31, 2024 · d5a9e5c · d5a9e5c
2 parents b5e41f6 + ca6a89b
commit d5a9e5c
Show file tree

Hide file tree

Showing 5 changed files with 95 additions and 126 deletions.
diff --git a/tests/opencl/j_stat/statistic.ipynb b/tests/opencl/j_stat/statistic.ipynb
diff --git a/tests/opencl/kernel1/main.cc b/tests/opencl/kernel1/main.cc
@@ -8,6 +8,7 @@
 #include <sys/resource.h>
 #include <time.h>
 #include <unistd.h>
+#include <math.h>
 
 #include "common.h"
 
@@ -62,6 +63,15 @@ static int read_kernel_file(const char *filename, uint8_t **data,
   return 0;
 }
 
+static bool float_compare(float f1, float f2)
+{
+    static constexpr auto epsilon = 1.0e-06f;
+
+    if (abs(f1 - f2) <= epsilon)
+        return true;
+    return abs(f1 - f2) <= epsilon * fmax(abs(f1), abs(f2));
+}
+
 static void sgemm_cpu(float *C, const float *A, const float *B, int M, int N,
                       int K) {
   for (int m = 0; m < M; ++m) {
@@ -265,7 +275,7 @@ int main(int argc, char **argv) {
   int errors = 0;
 
   for (size_t i = 0; i < size_t(M * N); i++)
-    if (C_cpu[i] != C[i])
+    if (!float_compare(C_cpu[i], C[i]))
       errors++;
   if (errors != 0)
     printf("FAILED! - %d errors\n", errors);

diff --git a/tests/opencl/kernel2/main.cc b/tests/opencl/kernel2/main.cc
@@ -8,6 +8,7 @@
 #include <sys/resource.h>
 #include <time.h>
 #include <unistd.h>
+#include <math.h>
 
 #include "common.h"
 
@@ -62,6 +63,15 @@ static int read_kernel_file(const char *filename, uint8_t **data,
   return 0;
 }
 
+static bool float_compare(float f1, float f2)
+{
+    static constexpr auto epsilon = 1.0e-06f;
+
+    if (abs(f1 - f2) <= epsilon)
+        return true;
+    return abs(f1 - f2) <= epsilon * fmax(abs(f1), abs(f2));
+}
+
 static void sgemm_cpu(float *C, const float *A, const float *B, int M, int N,
                       int K) {
   for (int m = 0; m < M; ++m) {
@@ -172,9 +182,9 @@ int main(int argc, char **argv) {
   }
   srand(time(NULL));
   for (int i = 0; i < M * K; i++)
-    A[i] = (int)((float)rand() / (float)RAND_MAX);
+    A[i] = ((float)rand() / (float)RAND_MAX);
   for (int i = 0; i < N * K; i++)
-    B[i] = (int)((float)rand() / (float)RAND_MAX);
+    B[i] = ((float)rand() / (float)RAND_MAX);
 
   // create buffers
   a_memobj =
@@ -265,7 +275,7 @@ int main(int argc, char **argv) {
   int errors = 0;
 
   for (size_t i = 0; i < size_t(M * N); i++)
-    if (C_cpu[i] != C[i])
+    if (!float_compare(C_cpu[i], C[i]))
       errors++;
   if (errors != 0)
     printf("FAILED! - %d errors\n", errors);

diff --git a/tests/opencl/kernel3/main.cc b/tests/opencl/kernel3/main.cc
@@ -8,6 +8,7 @@
 #include <sys/resource.h>
 #include <time.h>
 #include <unistd.h>
+#include <math.h>
 
 #include "common.h"
 
@@ -62,6 +63,15 @@ static int read_kernel_file(const char *filename, uint8_t **data,
   return 0;
 }
 
+static bool float_compare(float f1, float f2)
+{
+    static constexpr auto epsilon = 1.0e-06f;
+
+    if (abs(f1 - f2) <= epsilon)
+        return true;
+    return abs(f1 - f2) <= epsilon * fmax(abs(f1), abs(f2));
+}
+
 static void sgemm_cpu(float *C, const float *A, const float *B, int M, int N,
                       int K) {
   for (int m = 0; m < M; ++m) {
@@ -265,7 +275,7 @@ int main(int argc, char **argv) {
   int errors = 0;
 
   for (size_t i = 0; i < size_t(M * N); i++)
-    if (C_cpu[i] != C[i])
+    if (!float_compare(C_cpu[i], C[i]))
       errors++;
   if (errors != 0)
     printf("FAILED! - %d errors\n", errors);

diff --git a/tests/opencl/kernel4/main.cc b/tests/opencl/kernel4/main.cc
@@ -8,6 +8,7 @@
 #include <sys/resource.h>
 #include <time.h>
 #include <unistd.h>
+#include <math.h>
 
 #include "common.h"
 
@@ -62,6 +63,15 @@ static int read_kernel_file(const char *filename, uint8_t **data,
   return 0;
 }
 
+static bool float_compare(float f1, float f2)
+{
+    static constexpr auto epsilon = 1.0e-06f;
+
+    if (abs(f1 - f2) <= epsilon)
+        return true;
+    return abs(f1 - f2) <= epsilon * fmax(abs(f1), abs(f2));
+}
+
 static void sgemm_cpu(float *C, const float *A, const float *B, int M, int N,
                       int K) {
   for (int m = 0; m < M; ++m) {
@@ -265,7 +275,7 @@ int main(int argc, char **argv) {
   int errors = 0;
 
   for (size_t i = 0; i < size_t(M * N); i++)
-    if (C_cpu[i] != C[i])
+    if (!float_compare(C_cpu[i], C[i]))
       errors++;
   if (errors != 0)
     printf("FAILED! - %d errors\n", errors);