-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom qpdf binary #39
base: master
Are you sure you want to change the base?
Conversation
While this don't get merged, here's a patch I've made in case of anyone need:
|
@Sparticuz Can you please take a look to merge this? |
Thanks for the PR! Sorry it was a little bit before I could look at it. My main question is this. Can't you just add that directory to EDIT: what I mean by that is something like this process.env["PATH"] = `${process.env["PATH"]}:${path.join(process.cwd(),"qpdf_dir","bin")}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few notes. Thanks!
I'll see if can manage it to work using your suggestion. |
With this we can pass a custom
qpdf
binary path.If user wants to use source compiled or standalone versions of
qpdf
binaries.In my case I needed to use the standalone Linux binary release because
qpdf
cannot be installed nor used as a layer.Here's an example of usage: