Feature managed identity auth #94
Open
+412
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegy implementations. ManagedIdentityAuthStrategy now supported.
…n times. Added IntOrStringInt.
…entication strategy.
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
1 similar comment
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conf.json supports the managed-identity boolean property. When true, managed identity authentication will be used.
Refactored authentication logic out of RestClient into Authenticator along with AuthStrategy(s) including ManagedIdentityAuthStrategy. I did this because I didn't want to add more if/else logic to the RestClient than is already there.
GenericAuthStrategy is just the original collection of authentication logic that already existed. It could be broken up into additional AuthStrategy types.
Token was modified to handle either int or string integer json values for the expiration times. See IntOrStringInt.