Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-5066: Better error messaging when creating SSO providers #1010

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wes-mil
Copy link
Contributor

@wes-mil wes-mil commented Dec 12, 2024

Description

Add better API response when failing to create new SSO provider and change corresponding UI elements.

Motivation and Context

This PR addresses: BED-5066

Previously, a name conflict when creating a new SSO provider would provide an nondescript error which didn't provide the user with any actionable information.

How Has This Been Tested?

Attempting to create a new SSO provider with a duplicate name now returns a 409 status code with a descriptive error message. When this error is hit on the UI it indicates to the user what specifically went wrong.

Screenshots (optional):

Screenshot from 2024-12-11 20-57-43

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have met the contributing prerequisites
  • I have ensured that related documentation is up-to-date
    • Open API docs
    • Code comments (GoDocs / JSDocs)
  • I have followed proper test practices
    • Added/updated tests to cover my changes
    • All new and existing tests passed

Add better error messaging on UI for this case
@wes-mil wes-mil added enhancement New feature or request user interface A pull request containing changes affecting the UI code. api A pull request containing changes affecting the API code. labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api A pull request containing changes affecting the API code. enhancement New feature or request user interface A pull request containing changes affecting the UI code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant