Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #945: Adjust text of the edge AZAddSecret to consider App Instance Property Lock #946

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zh54321
Copy link

@zh54321 zh54321 commented Nov 8, 2024

Description

Adjust text of the edge AZAddSecret to consider App Instance Property Lock

Motivation and Context

This PR partially addresses: Issue #945

Since March 2024 all new App registrations have the app instance property lock enabled by default.
This will lead to more and more false positives with the edge AZAddSecret, since it is not possible anymore to add secrets to the Enterprise Application.

This small text adjustment should warn BloodHound users that it is only possible to add new Secrets to an Enterprise Application if it is not protected by the App Instance Property Lock configuration in the corresponding App Registration.

How Has This Been Tested?

Ran locally

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Text adjustment

Checklist:

Copy link

github-actions bot commented Nov 8, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


ZH54321 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant