Skip to content

Commit

Permalink
chore: remove warns
Browse files Browse the repository at this point in the history
  • Loading branch information
rvazarkar committed Jul 22, 2024
1 parent 959e1ea commit 3dea7e4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
9 changes: 3 additions & 6 deletions test/unit/GroupProcessorTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ namespace CommonLibTest
{
public class GroupProcessorTest
{
private readonly string _testDomainName;

private readonly Result<string>[] _testMembershipReturn =
{
Result<string>.Ok("CN=Domain Admins,CN=Users,DC=testlab,DC=local"),
Expand All @@ -40,26 +38,25 @@ public class GroupProcessorTest
public GroupProcessorTest(ITestOutputHelper testOutputHelper)
{
_testOutputHelper = testOutputHelper;
_testDomainName = "TESTLAB.LOCAL";
_baseProcessor = new GroupProcessor(new LdapUtils());
}

[Fact]
public async Task GroupProcessor_GetPrimaryGroupInfo_NullPrimaryGroupID_ReturnsNull()
public void GroupProcessor_GetPrimaryGroupInfo_NullPrimaryGroupID_ReturnsNull()
{
var result = GroupProcessor.GetPrimaryGroupInfo(null, null);
Assert.Null(result);
}

[WindowsOnlyFact]
public async Task GroupProcessor_GetPrimaryGroupInfo_ReturnsCorrectSID()
public void GroupProcessor_GetPrimaryGroupInfo_ReturnsCorrectSID()
{
var result = GroupProcessor.GetPrimaryGroupInfo("513", "S-1-5-21-3130019616-2776909439-2417379446-1105");
Assert.Equal("S-1-5-21-3130019616-2776909439-2417379446-513", result);
}

[Fact]
public async Task GroupProcessor_GetPrimaryGroupInfo_BadSID_ReturnsNull()
public void GroupProcessor_GetPrimaryGroupInfo_BadSID_ReturnsNull()
{
var result = GroupProcessor.GetPrimaryGroupInfo("513", "ABC123");
Assert.Null(result);
Expand Down
4 changes: 0 additions & 4 deletions test/unit/WellKnownPrincipalTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ public class WellKnownPrincipalTest : IDisposable
public WellKnownPrincipalTest(ITestOutputHelper testOutputHelper)
{
_testOutputHelper = testOutputHelper;
_testDomainName = "TESTLAB.LOCAL";
_testForestName = "FOREST.LOCAL";
}

#endregion
Expand Down Expand Up @@ -123,8 +121,6 @@ private static (string sid, string name, Label label)[] GetWellKnownPrincipals()
#region Private Members

private readonly ITestOutputHelper _testOutputHelper;
private readonly string _testDomainName;
private readonly string _testForestName;

#endregion

Expand Down

0 comments on commit 3dea7e4

Please sign in to comment.