chore: fix tests for real

SpecterOps · Jul 26, 2024 · 77615a9 · 77615a9
1 parent 5bc46d3
commit 77615a9
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/test/unit/GPOLocalGroupProcessorTest.cs b/test/unit/GPOLocalGroupProcessorTest.cs
@@ -147,13 +147,15 @@ public async Task GPOLocalGroupProcessor_ReadGPOLocalGroups_Null_Gpcfilesyspath(
             var processor = new GPOLocalGroupProcessor(mockLDAPUtils.Object);
             var testGPLinkProperty =
                 "[LDAP:/o=foo/ou=foo Group (ABC123)/cn=foouser (blah)123/dc=somedomain;0;][LDAP:/o=foo/ou=foo Group (ABC123)/cn=foouser (blah)123/dc=someotherdomain;2;]";
-            var result = await processor.ReadGPOLocalGroups(testGPLinkProperty, null);
+            var result = await processor.ReadGPOLocalGroups(testGPLinkProperty, "DC=Testlab,DC=Local");
 
-            Assert.NotNull(result);
-            Assert.Empty(result.AffectedComputers);
+            Assert.Single(result.AffectedComputers);
+            var actual = result.AffectedComputers.First();
+            Assert.Equal(Label.Computer, actual.ObjectType);
+            Assert.Equal("teapot", actual.ObjectIdentifier);
         }
 
-        [Fact]
+        [WindowsOnlyFact]
         public async Task GPOLocalGroupProcessor_ReadGPOLocalGroups() {
             var mockLDAPUtils = new Mock<ILdapUtils>(MockBehavior.Loose);
             var gpcFileSysPath = Path.GetTempPath();
@@ -179,19 +181,21 @@ public async Task GPOLocalGroupProcessor_ReadGPOLocalGroups() {
                 .Returns(mockComputerResults.ToAsyncEnumerable)
                 .Returns(mockGCPFileSysPathResults.ToAsyncEnumerable)
                 .Returns(Array.Empty<LdapResult<IDirectoryObject>>().ToAsyncEnumerable);
+            var domain = MockableDomain.Construct("TESTLAB.LOCAL");
+            mockLDAPUtils.Setup(x => x.GetDomain(out domain)).Returns(true);
 
             var processor = new GPOLocalGroupProcessor(mockLDAPUtils.Object);
+
 
             var testGPLinkProperty =
                 "[LDAP:/o=foo/ou=foo Group (ABC123)/cn=foouser (blah)123/dc=somedomain;0;][LDAP:/o=foo/ou=foo Group (ABC123)/cn=foouser (blah)123/dc=someotherdomain;2;]";
             var result = await processor.ReadGPOLocalGroups(testGPLinkProperty, null);
-
-            var domain = MockableDomain.Construct("TESTLAB.LOCAL");
-            mockLDAPUtils.Setup(x => x.GetDomain(out domain)).Returns(true);
-
+
             //mockLDAPUtils.VerifyAll();
-            Assert.NotNull(result);
-            Assert.Empty(result.AffectedComputers);
+            Assert.Single(result.AffectedComputers);
+            var actual = result.AffectedComputers.First();
+            Assert.Equal(Label.Computer, actual.ObjectType);
+            Assert.Equal("teapot", actual.ObjectIdentifier);
         }
 
         [Fact]