Check if ResolveAccountName returns a value

SpecterOps · Dec 23, 2023 · 920514f · 920514f
1 parent da6b83c
commit 920514f
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/CommonLib/Processors/GPOLocalGroupProcessor.cs b/src/CommonLib/Processors/GPOLocalGroupProcessor.cs
@@ -531,6 +531,11 @@ internal IEnumerable<GroupAction> ProcessGPOXmlFile(string basePath, string gpoD
                                     var domain = s[0];
 
                                     var res = _utils.ResolveAccountName(name, domain);
+                                    if (res == null)
+                                    {
+                                        _log.LogWarning("Failed to resolve member {memberName}", memberName);
+                                        continue;
+                                    }
                                     ga.Target = GroupActionTarget.LocalGroup;
                                     ga.TargetSid = res.ObjectIdentifier;
                                     ga.TargetType = res.ObjectType;
@@ -540,6 +545,11 @@ internal IEnumerable<GroupAction> ProcessGPOXmlFile(string basePath, string gpoD
                                 else
                                 {
                                     var res = _utils.ResolveAccountName(memberName, gpoDomain);
+                                    if (res == null)
+                                    {
+                                        _log.LogWarning("Failed to resolve member {memberName}", memberName);
+                                        continue;
+                                    }
                                     ga.Target = GroupActionTarget.LocalGroup;
                                     ga.TargetSid = res.ObjectIdentifier;
                                     ga.TargetType = res.ObjectType;