chore: supress/fix nits

SpecterOps · Jul 22, 2024 · f062342 · f062342
1 parent 7757f2f
commit f062342
Show file tree

Hide file tree

Showing 13 changed files with 28 additions and 4 deletions.
diff --git a/test/unit/ContainerProcessorTest.cs b/test/unit/ContainerProcessorTest.cs
@@ -121,7 +121,7 @@ public async Task ContainerProcessor_GetContainerChildObjects_ReturnsCorrectData
         }
 
         [Fact]
-        public async Task ContainerProcessor_ReadBlocksInheritance_ReturnsCorrectValues()
+        public void ContainerProcessor_ReadBlocksInheritance_ReturnsCorrectValues()
         {
             var test = ContainerProcessor.ReadBlocksInheritance(null);
             var test2 = ContainerProcessor.ReadBlocksInheritance("3");

diff --git a/test/unit/Facades/LSAMocks/DCMocks/MockDCLSAPolicy.cs b/test/unit/Facades/LSAMocks/DCMocks/MockDCLSAPolicy.cs
@@ -1,12 +1,14 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Security.Principal;
 using SharpHoundRPC;
 using SharpHoundRPC.Shared;
 using SharpHoundRPC.Wrappers;
 
 namespace CommonLibTest.Facades.LSAMocks.DCMocks
 {
+    [SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
     public class MockDCLSAPolicy : ILSAPolicy
     {
         public Result<(string Name, string Sid)> GetLocalDomainInformation()

diff --git a/test/unit/Facades/LSAMocks/WorkstationMocks/MockWorkstationLSAPolicy.cs b/test/unit/Facades/LSAMocks/WorkstationMocks/MockWorkstationLSAPolicy.cs
@@ -1,12 +1,14 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Security.Principal;
 using SharpHoundRPC;
 using SharpHoundRPC.Shared;
 using SharpHoundRPC.Wrappers;
 
 namespace CommonLibTest.Facades.LSAMocks.WorkstationMocks
 {
+    [SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
     public class MockWorkstationLSAPolicy : ILSAPolicy
     {
         public Result<(string Name, string Sid)> GetLocalDomainInformation()

diff --git a/test/unit/Facades/MockLdapUtils.cs b/test/unit/Facades/MockLdapUtils.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.DirectoryServices.ActiveDirectory;
 using System.Linq;
 using System.Security.Principal;
@@ -16,6 +17,7 @@
 
 namespace CommonLibTest.Facades
 {
+    [SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
     public class MockLdapUtils : ILdapUtils
     {
         private readonly ConcurrentDictionary<string, byte> _domainControllers = new();

diff --git a/test/unit/Facades/MockableDomain.cs b/test/unit/Facades/MockableDomain.cs
@@ -1,7 +1,9 @@
-using System.DirectoryServices.ActiveDirectory;
+using System.Diagnostics.CodeAnalysis;
+using System.DirectoryServices.ActiveDirectory;
 
 namespace CommonLibTest.Facades
 {
+    [SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
     public class MockableDomain
     {
         public static Domain Construct(string domainName)

diff --git a/test/unit/Facades/MockableForest.cs b/test/unit/Facades/MockableForest.cs
@@ -1,7 +1,9 @@
-using System.DirectoryServices.ActiveDirectory;
+using System.Diagnostics.CodeAnalysis;
+using System.DirectoryServices.ActiveDirectory;
 
 namespace CommonLibTest.Facades
 {
+    [SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
     public class MockableForest
     {
         public static Forest Construct(string forestDnsName)

diff --git a/test/unit/Facades/SAMMocks/DCMocks/MockDCAliasAdministrators.cs b/test/unit/Facades/SAMMocks/DCMocks/MockDCAliasAdministrators.cs
@@ -1,10 +1,12 @@
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Security.Principal;
 using SharpHoundRPC;
 using SharpHoundRPC.Wrappers;
 
 namespace CommonLibTest.Facades
 {
+    [SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
     public class MockDCAliasAdministrators : ISAMAlias
     {
         public Result<IEnumerable<SecurityIdentifier>> GetMembers()

diff --git a/test/unit/Facades/SAMMocks/DCMocks/MockDCAliasUsers.cs b/test/unit/Facades/SAMMocks/DCMocks/MockDCAliasUsers.cs
@@ -1,10 +1,12 @@
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Security.Principal;
 using SharpHoundRPC;
 using SharpHoundRPC.Wrappers;
 
 namespace CommonLibTest.Facades
 {
+    [SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
     public class MockDCAliasUsers : ISAMAlias
     {
         public Result<IEnumerable<SecurityIdentifier>> GetMembers()

diff --git a/test/unit/Facades/SAMMocks/DCMocks/MockDCSAMServer.cs b/test/unit/Facades/SAMMocks/DCMocks/MockDCSAMServer.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Security.Principal;
 using SharpHoundRPC;
 using SharpHoundRPC.SAMRPCNative;
@@ -8,6 +9,7 @@
 
 namespace CommonLibTest.Facades
 {
+    [SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
     public class MockDCSAMServer : ISAMServer
     {
         public bool IsNull { get; }

diff --git a/test/unit/Facades/SAMMocks/WorkstationMocks/MockWorkstationAliasAdministrators.cs b/test/unit/Facades/SAMMocks/WorkstationMocks/MockWorkstationAliasAdministrators.cs
@@ -1,10 +1,12 @@
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Security.Principal;
 using SharpHoundRPC;
 using SharpHoundRPC.Wrappers;
 
 namespace CommonLibTest.Facades
 {
+    [SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
     public class MockWorkstationAliasAdministrators : ISAMAlias
     {
         public Result<IEnumerable<SecurityIdentifier>> GetMembers()

diff --git a/test/unit/Facades/SAMMocks/WorkstationMocks/MockWorkstationAliasRDP.cs b/test/unit/Facades/SAMMocks/WorkstationMocks/MockWorkstationAliasRDP.cs
@@ -1,10 +1,12 @@
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Security.Principal;
 using SharpHoundRPC;
 using SharpHoundRPC.Wrappers;
 
 namespace CommonLibTest.Facades
 {
+    [SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
     public class MockWorkstationAliasRDP : ISAMAlias
     {
         public Result<IEnumerable<SecurityIdentifier>> GetMembers()

diff --git a/test/unit/Facades/SAMMocks/WorkstationMocks/MockWorkstationAliasTestGroup.cs b/test/unit/Facades/SAMMocks/WorkstationMocks/MockWorkstationAliasTestGroup.cs
@@ -1,10 +1,12 @@
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Security.Principal;
 using SharpHoundRPC;
 using SharpHoundRPC.Wrappers;
 
 namespace CommonLibTest.Facades
 {
+    [SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
     public class MockWorkstationAliasTestGroup : ISAMAlias
     {
         public Result<IEnumerable<SecurityIdentifier>> GetMembers()

diff --git a/test/unit/Facades/SAMMocks/WorkstationMocks/MockWorkstationSAMServer.cs b/test/unit/Facades/SAMMocks/WorkstationMocks/MockWorkstationSAMServer.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Security.Principal;
 using SharpHoundRPC;
 using SharpHoundRPC.SAMRPCNative;
@@ -8,6 +9,7 @@
 
 namespace CommonLibTest.Facades
 {
+    [SuppressMessage("Interoperability", "CA1416:Validate platform compatibility")]
     public class MockWorkstationSAMServer : ISAMServer
     {
         public bool IsNull { get; }
@@ -23,7 +25,7 @@ public class MockWorkstationSAMServer : ISAMServer
 
         public Result<SecurityIdentifier> LookupDomain(string name)
         {
-            throw new System.NotImplementedException();
+            throw new NotImplementedException();
         }
 
         public Result<SecurityIdentifier> GetMachineSid(string testName = null)