Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When reading computer properties ignore hosts not resolved to SIDs #109

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

definitelynotagoblin
Copy link
Contributor

Description

We don't want to record computer host properies that aren't proper SIDs

Motivation and Context

https://specterops.atlassian.net/browse/BP-508

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@definitelynotagoblin definitelynotagoblin enabled auto-merge (squash) March 14, 2024 15:45
@definitelynotagoblin definitelynotagoblin merged commit d489c47 into v3 Mar 14, 2024
3 checks passed
@definitelynotagoblin definitelynotagoblin deleted the anemeth/computers-ignore-hostnames branch March 14, 2024 15:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants