Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BED-4342] Don't throw on Server Down (unless we want to) #119

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

definitelynotagoblin
Copy link
Contributor

Description

LDAPQuery throws exception when a DC can't be reached after it's exhausted its retries, whether or not our throwException flag is set.

Motivation and Context

https://specterops.atlassian.net/browse/BP-642

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@definitelynotagoblin definitelynotagoblin changed the title Don't throw on Server Down (unless we want to) [BED-4342] Don't throw on Server Down (unless we want to) Apr 24, 2024
@rvazarkar rvazarkar merged commit 5257b63 into v3 Apr 25, 2024
3 checks passed
@rvazarkar rvazarkar deleted the anemeth/ldapQuery-dont-throw-on-server-down branch April 25, 2024 18:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants