Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bed-4487: fix handling for unicode control characters #141

Merged
merged 11 commits into from
Jul 26, 2024
Merged

Conversation

mistahj67
Copy link
Contributor

Description

Closes BED-4487

Add protection around control characters such as null unicode \u0000by base64 encoding any properties we encounter.

Motivation and Context

Running the collection with --collectallproperties brings in properties with binary control characters that cause issues downstream during ingestion into db's.

How Has This Been Tested?

Added unit tests
Tested on AD lab

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@rvazarkar rvazarkar merged commit 15553c2 into v4 Jul 26, 2024
3 checks passed
@rvazarkar rvazarkar deleted the BED-4487 branch July 26, 2024 20:32
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants