Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly append relative search base #144

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Properly append relative search base #144

merged 4 commits into from
Jul 29, 2024

Conversation

rvazarkar
Copy link
Contributor

Description

The logic for relative search base was in the wrong block

Motivation and Context

Fixes certificate template resolution

How Has This Been Tested?

Tested locally in a lab

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@rvazarkar rvazarkar merged commit 1907029 into v4 Jul 29, 2024
3 checks passed
@rvazarkar rvazarkar deleted the relative_searchbase_fix branch July 29, 2024 14:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants