Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an exception, and a couple missing properties #149

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix an exception, and a couple missing properties #149

merged 1 commit into from
Jul 31, 2024

Conversation

rvazarkar
Copy link
Contributor

@rvazarkar rvazarkar commented Jul 31, 2024 •
edited
Loading

Description

Safe check adding to the dictionary and add missing properties

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@rvazarkar
fix: exception when adding keys
2b79838 
fix: couple missing properties
chore: bump version
JonasBK
JonasBK approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@JonasBK JonasBK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@rvazarkar rvazarkar merged commit 1f5e96a into v4 Jul 31, 2024
3 checks passed
@rvazarkar rvazarkar deleted the bump_version branch July 31, 2024 13:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JonasBK JonasBK JonasBK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvazarkar @JonasBK