Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add more unit tests and some xml documentation coverage #77

Merged
merged 1 commit into from
Oct 4, 2023
Merged

chore: add more unit tests and some xml documentation coverage #77

merged 1 commit into from
Oct 4, 2023

Conversation

urangel
Copy link
Contributor

@urangel urangel commented Oct 4, 2023

Description

Adds more unit tests and some xml documentation to new read property methods

Motivation and Context

Improving code hygiene

How Has This Been Tested?

Ran tests locally

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@urangel urangel merged commit c950fb3 into adcs Oct 4, 2023
3 checks passed
@urangel urangel deleted the coverage-two-electric-boogaloo branch October 4, 2023 22:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rvazarkar rvazarkar rvazarkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urangel @rvazarkar