Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerDown Retry Logic #79

Merged
merged 1 commit into from
Oct 12, 2023
Merged

ServerDown Retry Logic #79

merged 1 commit into from
Oct 12, 2023

Conversation

rvazarkar
Copy link
Contributor

Description

This MR adds logic if we hit a serverdown to create a new ldap connectin and retry the search

Motivation and Context

Occasionally, we get kicked off the ldap server because reasons. In theory we should be able to retry the request with the same cookie after a delay to let the LDAP server get itself together.

How Has This Been Tested?

Unfortunately, no real way to test this, this is experimental logic since we cant repro this in any lab

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@rvazarkar rvazarkar merged commit 90fab4c into v3 Oct 12, 2023
3 checks passed
@rvazarkar rvazarkar deleted the serverdown_retry branch October 12, 2023 15:14
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants