Test/fluid strategy #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est/fluidStrategy
arcantheon
reviewed
Dec 9, 2024
arcantheon
reviewed
Dec 9, 2024
arcantheon
reviewed
Dec 9, 2024
arcantheon
reviewed
Dec 9, 2024
arcantheon
reviewed
Dec 9, 2024
… allocate from vault to strategy
…_Store is ignored
…ge, and enhance allocation logic
parv3213
reviewed
Dec 14, 2024
… into test/fluidStrategy
YashP16
added a commit
that referenced
this pull request
Dec 20, 2024
* feat(Fluid strategy): Added base functions without implementation and initialize function * feat(FluidStrategy): Implemented deposit and withdraw functionality * Removed setting p token in initialization * Added setPTokenAddress functionality * fix(_abstractSetPToken): Error in if condition fixed * Added validations and updated event * Used redeem instead of withdraw and previewWithdraw instead of convertToShares * Implemented all the remaining functionalities * refactor(Strategy): Added error message and documentation * perf(Strategy deposit and withdraw): Implemented stricter checks * Removed unused functions from interface * perf(strategy): Removed named returns * Removed temp variable maxDeposit * Update contracts/strategies/fluid/FluidStrategy.sol Co-authored-by: Parv Garg <[email protected]> * refactor(Fluid token interface): changed the name * fix(deposit): Added post slippage check * feat(Deposit and Withdraw): Added slippage checks * Added deployment config for fluid strategy * Test/fluid strategy (#70) * Added base test script and setup * Updated interface * Added a sample test * Fixed the precision error * Removed unused functions from the interface * fix(package): update forge-coverage script and dependencies * feat(config): add RPC endpoint for Arbitrum and ensure cache path is defined * fix(test): simplify Arbitrum fork setup by combining creation and selection * Test(FluidStrategy): 93.2% of lines, 100% of the functions covered * fix(test): format spacing in FluidStrategy test for consistency * fix(test): improve test coverage for FluidStrategy by adding missing cases * fix(test): rename variables for clarity and improve revert messages in FluidStrategy tests * fix(test): rename test function for clarity in FluidStrategy tests * Fixed aave strategy's test cases * Revert "Fixed aave strategy's test cases" This reverts commit b55f300. * Fixed test case to support interface name change * Fixed failing test cases * Fixed failing test case (testFuzz_deposit) * Revert "Fixed failing test case (testFuzz_deposit)" This reverts commit 4932bc6. * Updated slippage and it's comment to 4% * Added test for the new condition in deposit * feat(Deposit and Withdraw): Added slippage checks * Revert "feat(Deposit and Withdraw): Added slippage checks" This reverts commit 93dbc96. * Fixed failing test * Reverted the change to create fork * test(FluidStrategy): Enhance tests for deposit and withdrawal slippage handling * test(WithdrawTest): Fix formatting and enhance revert checks for withdrawal scenarios * Added back createSelectFork function * fix(package.json): update forge-coverage script to handle additional ignore errors * docs(foundry.toml): Added comment for explicit evm version declaration * feat(BaseTest): add COLLATERAL_MANAGER address to contract initialization * feat(FluidStrategyTest): implement collateral strategy allocation and allocate from vault to strategy * chore(.gitignore): add gambit_out for mutation testing and ensure .DS_Store is ignored * refactor(FluidStrategyTest): reorganize tests, update withdraw slippage, and enhance allocation logic * Added simulation script for fluid strategy * Fixed forking issue * chore(.gitignore): add testLogs to ignore list for cleaner mutation testing output * fix(foundry.toml): remove unused rpc_endpoints section * fix(foundry.toml): add rpc_endpoints section for Arbitrum --------- Co-authored-by: [email protected] <[email protected]> * feat(deployment): Add deployment configuration for fluid strategy * feat(FluidStrategy): Add FLUID_STRATEGY constant and update withdrawal logic in tests --------- Co-authored-by: Parv Garg <[email protected]> Co-authored-by: Dayaa <[email protected]> Co-authored-by: Yash Pitroda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to configuration files and updates to dependencies. The most important changes include adding RPC endpoints, updating the coverage command, and modifying the fork setup in tests.
Configuration updates:
FluidStrategy: 93.2% of lines and 100% of functions were coveredfoundry.toml: Added RPC endpoints for Arbitrum.Dependency updates:
package.json: Updatedhuskyto version 9.1.7 andsolhintto version 5.0.3.Coverage command improvements:
package.json: Enhanced theforge-coveragecommand to include branch coverage and function end line derivation.Test setup improvements:
test/utils/BaseTest.sol: Modified thesetArbitrumForkfunction to usecreateSelectForkwith a block number parameter for more control over the fork setup.