Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back multi-vp handling #183

Conversation

TimoGlastra
Copy link
Contributor

Same as #182 but to main instead of the mdoc branch. @sanderPostma so you can decide if you can merge it as part of mdoc or do it separately.

Basically it doesn't allow the $ to be used if the presentations is an array, or vice versa $[0] if it's an object. Should be an easy fix, but you code does need to handle what it passes in (important whther an array with 1 entry or an object is passed)

Signed-off-by: Timo Glastra <[email protected]>
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.65%. Comparing base (772a058) to head (41c83d3).
Report is 28 commits behind head on develop.

Files with missing lines Patch % Lines
lib/evaluation/evaluationClientWrapper.ts 65.21% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #183      +/-   ##
===========================================
- Coverage    92.81%   92.65%   -0.16%     
===========================================
  Files           66       66              
  Lines         2728     2737       +9     
  Branches       711      717       +6     
===========================================
+ Hits          2532     2536       +4     
- Misses         190      195       +5     
  Partials         6        6              
Flag Coverage Δ
unittest 92.65% <65.21%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant