ibCredentialLocaleBrandingFrom error handling #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BtencateSphereon
requested changes
Mar 15, 2024
| try { | ||
| return await ibCredentialLocaleBrandingFrom({localeBranding: await credentialLocaleBrandingFrom(display)}); | ||
| } catch (e) { | ||
| console.error(`Could not fetch branding. Branding data: ${JSON.stringify(display)}`); |
There was a problem hiding this comment.
i am not sure if this is the way we should handle this. Also what situation did you have where the branding was not present?
There was a problem hiding this comment.
Images could be unavailable because of a network issue for instance. I rather have us accept the credential without branding then having an error because of branding issues.
If I remember correctly it was a case where the image could not be found, right @sander
There was a problem hiding this comment.
should we then not fix that in the plugin instead of the wallet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.