Improve eventloop consistency and isClosing code #3779
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All channel calls need to be in a eventloop context. if they are not, netty will put them in context. (this costs performance)
After nearly all event calls there is a call with the netty channel. So we should reschedule to the channel eventloop if we are not in the channels eventloop context.
I added a small wrapper to solve this problem where i also added the channel closing checks so we don't have to add them anywhere we have an event.