Skip to content

Commit

Permalink
github-259: remove shiftFunction configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
ArturMoczulski committed Sep 4, 2017
1 parent bd27c55 commit 1a514da
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 21 deletions.
7 changes: 0 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -521,13 +521,6 @@ Default: `('passwd', 'password', 'secret', 'confirm_password', 'password_confirm
<dd>Array of fields that you do NOT to be scrubbed even if they match entries in scrub_fields. Entries should be provided in associative array dot notation, i.e. `data.person.username`.
</dd>

<dt>shift_function
</dt>
<dd>Whether to shift function names in stack traces down one frame, so that the function name correctly reflects the context of each frame.

Default: `true`
</dd>

<dt>timeout
</dt>
<dd>Request timeout for posting to rollbar, in seconds.
Expand Down
13 changes: 0 additions & 13 deletions src/DataBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ class DataBuilder implements DataBuilderInterface
protected $baseException;
protected $includeCodeContext;
protected $includeExcCodeContext;
protected $shiftFunction;
protected $sendMessageTrace;
protected $rawRequestBody;
protected $localVarsDump;
Expand Down Expand Up @@ -99,11 +98,6 @@ public function __construct($config)
$this->setLocalVarsDump($config);
$this->setCaptureErrorStacktraces($config);
$this->setLevelFactory($config);

$this->shiftFunction = $this->tryGet($config, 'shift_function');
if (!isset($this->shiftFunction)) {
$this->shiftFunction = true;
}
}

protected function tryGet($array, $key)
Expand Down Expand Up @@ -463,13 +457,6 @@ public function makeFrames($exception, $includeContext)

$frames[] = $frame;
}

if ($this->shiftFunction && count($frames) > 0) {
for ($i = count($frames) - 1; $i > 0; $i--) {
$frames[$i]->setMethod($frames[$i - 1]->getMethod());
}
$frames[0]->setMethod('<main>');
}

$frames = array_reverse($frames);

Expand Down
1 change: 0 additions & 1 deletion tests/BackwardsCompatibilityConfigTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ public function testConfigValues()
},
'root' => '/Users/brian/www/app',
'scrub_fields' => array('test'),
'shift_function' => false,
'timeout' => 10,
'report_suppressed' => true,
'use_error_reporting' => true,
Expand Down

0 comments on commit 1a514da

Please sign in to comment.