Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup 19of20: Axi4.py: local variable maybe used before initialization start,end (MED) #30

Open
wants to merge 72 commits into
base: master
Choose a base branch
from

Conversation

dlmiles
Copy link

@dlmiles dlmiles commented May 17, 2023

MEDIUM risk changes (linter recommendation)

This is a FAST-FORWARD on top of 18of20, merge with rebase.

20of20 (dlmiles/SpinalHDL-CocotbLib.git#f705aa3e8) test results below:

# git log -n3 --oneline --format="%h %d %cd %s"
b092475ca  (HEAD -> dev) Wed May 17 10:37:37 2023 +0000 .gitmodules: ADDED https://github.com/dlmiles/SpinalHDL-CocotbLib.git#dlm-cleanup#f705aa3e8c
e26329834  Wed May 17 10:36:57 2023 +0000 .gitmodules: REMOVE
d15b083a7  (github/dev) Tue May 16 13:23:25 2023 +0100 Add PhaseRandomizedMem
# git diff HEAD~2..HEAD
diff --git a/.gitmodules b/.gitmodules
index 0bb3f0921..073f2a372 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,3 +1,4 @@
 [submodule "tester/src/test/python/cocotblib"]
        path = tester/src/test/python/cocotblib
-       url = https://github.com/SpinalHDL/CocotbLib.git
+       url = https://github.com/dlmiles/SpinalHDL-CocotbLib.git
+       branch = dlm-cleanup
diff --git a/tester/src/test/python/cocotblib b/tester/src/test/python/cocotblib
index a98830423..f705aa3e8 160000
--- a/tester/src/test/python/cocotblib
+++ b/tester/src/test/python/cocotblib
@@ -1 +1 @@
-Subproject commit a98830423924fc89bfebae84cb802fc90d352602
+Subproject commit f705aa3e8c9ed4e9290f50e6051ef353a5121113

dlmiles added 29 commits May 15, 2023 17:26
requirements_lint.txt  added for this task
@dlmiles dlmiles changed the title Cleanup 19of20: Axi4.py: local variable maybe used before initialization start,end Cleanup 19of20: Axi4.py: local variable maybe used before initialization start,end (MED) May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant