Audio: convert seconds to samples by rounding rather than flooring

Splendide-Imaginarius · Sep 27, 2024 · 6a3a0dd · 6a3a0dd
1 parent c58d708
commit 6a3a0dd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/audio/sdlsoundsource.cpp b/src/audio/sdlsoundsource.cpp
@@ -153,9 +153,8 @@ struct SDLSoundSource : ALDataSource
 		else
 		{
 			// Unfortunately there is no easy API in SDL_sound for seeking with better precision than 1ms.
-			// TODO: Work around this by manually consuming the remaining samples.
-			// TODO: Also we're flooring here when we probably should be rounding.
-			Sound_Seek(sample, static_cast<uint32_t>(seconds * 1000));
+			// TODO: Work around this by flooring instead of rounding, and then manually consuming the remaining samples.
+			Sound_Seek(sample, static_cast<uint32_t>(lround(seconds * 1000)));
 		}
 	}
 

diff --git a/src/audio/vorbissource.cpp b/src/audio/vorbissource.cpp
@@ -164,8 +164,7 @@ struct VorbisSource : ALDataSource
 			currentFrame = 0;
 		}
 
-		// TODO: We're flooring here when we probably should be rounding.
-		currentFrame = seconds * info.rate;
+		currentFrame = lround(seconds * info.rate);
 
 		if (loop.valid && currentFrame > loop.end)
 			currentFrame = loop.start;