Bug Fix: Change the application order of src and srcset to suppre…

…ss the `NS_BINDING_ABORTED` notice(#632).
Splidejs · Jan 26, 2022 · 5e0c2ac · 5e0c2ac
1 parent 0201f9d
commit 5e0c2ac
Show file tree

Hide file tree

Showing 10 changed files with 18 additions and 16 deletions.
diff --git a/dist/js/splide-renderer.min.js b/dist/js/splide-renderer.min.js
diff --git a/dist/js/splide.cjs.js b/dist/js/splide.cjs.js
@@ -1,6 +1,6 @@
 /*!
  * Splide.js
- * Version  : 3.6.11
+ * Version  : 3.6.12
  * License  : MIT
  * Copyright: 2022 Naotoshi Fujita
  */
@@ -2037,7 +2037,7 @@ function LazyLoad(Splide2, Components2, options) {
     bind(_img, "load error", (e) => {
       onLoad(data, e.type === "error");
     });
-    ["src", "srcset"].forEach((name) => {
+    ["srcset", "src"].forEach((name) => {
       if (data[name]) {
         setAttribute(_img, name, data[name]);
         removeAttribute(_img, name === "src" ? SRC_DATA_ATTRIBUTE : SRCSET_DATA_ATTRIBUTE);

diff --git a/dist/js/splide.esm.js b/dist/js/splide.esm.js
@@ -1,6 +1,6 @@
 /*!
  * Splide.js
- * Version  : 3.6.11
+ * Version  : 3.6.12
  * License  : MIT
  * Copyright: 2022 Naotoshi Fujita
  */
@@ -2033,7 +2033,7 @@ function LazyLoad(Splide2, Components2, options) {
     bind(_img, "load error", (e) => {
       onLoad(data, e.type === "error");
     });
-    ["src", "srcset"].forEach((name) => {
+    ["srcset", "src"].forEach((name) => {
       if (data[name]) {
         setAttribute(_img, name, data[name]);
         removeAttribute(_img, name === "src" ? SRC_DATA_ATTRIBUTE : SRCSET_DATA_ATTRIBUTE);

diff --git a/dist/js/splide.js b/dist/js/splide.js
diff --git a/dist/js/splide.js.map b/dist/js/splide.js.map
diff --git a/dist/js/splide.min.js b/dist/js/splide.min.js
diff --git a/dist/js/splide.min.js.gz b/dist/js/splide.min.js.gz
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@splidejs/splide",
-  "version": "3.6.11",
+  "version": "3.6.12",
   "description": "Splide is a lightweight, flexible and accessible slider/carousel. No dependencies, no Lighthouse errors.",
   "author": "Naotoshi Fujita",
   "license": "MIT",

diff --git a/src/js/components/LazyLoad/LazyLoad.ts b/src/js/components/LazyLoad/LazyLoad.ts
@@ -5,13 +5,15 @@ import {
   EVENT_MOUNTED,
   EVENT_MOVED,
   EVENT_REFRESH,
-  EVENT_RESIZE, EVENT_SCROLLED,
+  EVENT_RESIZE,
+  EVENT_SCROLLED,
 } from '../../constants/events';
 import { EventInterface } from '../../constructors';
 import { Splide } from '../../core/Splide/Splide';
 import { BaseComponent, Components, Options } from '../../types';
 import {
-  addClass, child,
+  addClass,
+  child,
   create,
   display,
   getAttribute,
@@ -158,7 +160,7 @@ export function LazyLoad( Splide: Splide, Components: Components, options: Optio
     addClass( data._Slide.slide, CLASS_LOADING );
     bind( _img, 'load error', e => { onLoad( data, e.type === 'error' ) } );
 
-    [ 'src', 'srcset' ].forEach( name => {
+    [ 'srcset', 'src' ].forEach( name => {
       if ( data[ name ] ) {
         setAttribute( _img, name, data[ name ] );
         removeAttribute( _img, name === 'src' ? SRC_DATA_ATTRIBUTE : SRCSET_DATA_ATTRIBUTE );