Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: frontend: extract scripts #38

Draft
wants to merge 3 commits into
base: spoon/yanxi-frontend-improved
Choose a base branch
from

Conversation

Spoonbaker
Copy link
Owner

This is a work in progress; I am creating this as a starting point for the frontend team. This can be merged after #36; The target branch will be updated automatically.

Also note that currently all buttons that rely on onclick= don't work, as the dev CSP blocks them. The onclick= handlers will need to be changed, see below.

Tasks that need to get done:

  • Don't set .innerHTML anywhere
  • Turn onclick= handlers into <element>.addEventListener("click", <function>)
  • Make rpm run check pass
    • The @ts-ignore directive is temporarily hiding some errors. Remove the directive and fix the errors
    • Remove unused declarations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant