Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

試合結果入力画面 Feature/#32 match result #37

Merged
merged 9 commits into from
May 18, 2024

Conversation

1nayu
Copy link
Member

@1nayu 1nayu commented May 17, 2024

チケット

#32

概要

試合結果入力画面のほか、ルートの変更と一部スタイルの修正が含まれます。

細かな修正

  • リーグ、トーナメントページのルートを変更しました
  • ナビゲーションからリーグとトーナメントを削除し、使用頻度の多いボタンを上に配置しました

試合結果入力画面

ルートは /sports/[id]/[gameId]/[matchId] です
スクリーンショット 2024-05-17 22 33 23

  • 試合結果を半角数字で入力することができます
  • 「勝ったのは」セクションで得点の多い方のチームが選択されます。得点が同じ場合は引き分けになります。
  • 「試合の状態」セクションでは得点が入力されると完了が選択されます。

@1nayu 1nayu requested a review from testusuke May 17, 2024 13:36
@1nayu 1nayu self-assigned this May 17, 2024
Copy link
Member

@testusuke testusuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確かにその方がいいね

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほどここにデータを入れればいい感じですか

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そう!!お願いします🙇

@1nayu 1nayu merged commit 7ac2d75 into main May 18, 2024
1 check passed
@1nayu 1nayu deleted the feature/#32-match-result branch May 18, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants