Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

リンク修正など Feature/fix link #70

Merged
merged 11 commits into from
Oct 30, 2024
Merged

リンク修正など Feature/fix link #70

merged 11 commits into from
Oct 30, 2024

Conversation

1nayu
Copy link
Member

@1nayu 1nayu commented Oct 30, 2024

概要

  • Match Card（進行中の試合カード）の競技アイコンに画像を表示
  • ダッシュボードのお知らせボタンをサブディレクトリに対応
  • お知らせと画像を作成・編集時にリロードしないとAg-Gridに反映されない問題を修正
  • 選択コンポーネントに必要なvariantを追加
  • sportCreatorで画像リストの画像が表示されていない問題を修正
  • sportCreatorとsportEditorの画像選択部分のアラインを修正
  • プライバシーポリシーを更新
  • ダークモード対応

@1nayu 1nayu requested a review from testusuke October 30, 2024 02:07
@1nayu 1nayu self-assigned this Oct 30, 2024
testusuke
testusuke requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@testusuke testusuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

router.push()で画面遷移しているから router.refresh()は不要だと思っています。

他の変更は LGTMです！

components/images/imageCreator.tsx Outdated Show resolved Hide resolved
components/information/informationCreator.tsx Outdated Show resolved Hide resolved
components/information/informationEditor.tsx Outdated Show resolved Hide resolved
@1nayu 1nayu requested a review from testusuke October 30, 2024 10:30
testusuke
testusuke approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@testusuke testusuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@1nayu 1nayu merged commit f359974 into main Oct 30, 2024
1 check passed
@1nayu 1nayu deleted the feature/fix-link branch October 30, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testusuke testusuke testusuke approved these changes

Assignees

@1nayu 1nayu

Labels
Problem: bug Type: improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1nayu @testusuke