Misc style fixes #1340
Merged
Misc style fixes #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 7, 2023
| QuotedString, Word, ZeroOrMore, alphanums, nums, oneOf | ||
|
|
||
| from .errors import * | ||
| from pyparsing import Combine, Forward, Group, Literal, nestedExpr, \ |
| @@ -109,7 +109,7 @@ def reqError(self, req, error): | |||
| # print 'error', error | |||
|
|
|||
| def setupReqs(self): | |||
| for i in range(0, self.concurrent_reqs): # make the initial pool of requests | |||
| for _i in range(0, self.concurrent_reqs): # make the initial pool of requests | |||
| @@ -354,7 +353,7 @@ def test_vrf_add_list(self): | |||
| self.assertEqual(self._mangle_vrf_result(s.list_vrf({ 'auth': ad, 'vrf': { 'id': vrf['id'] } })), [ ref, ]) | |||
|
|
|||
| attr['rt'] = '123:abc' | |||
| with self.assertRaisesRegex(xmlrpc.client.Fault, '.'): # TODO: specify exception string | |||
| with self.assertRaisesRegex(xmlrpc.client.Fault, '.'): # TODO: specify exception string | |||
| # _exit is like exit(), but it doesn't call any functions registered | ||
| # with atexit (and on_exit) or any registered signal handlers. It also | ||
| # closes any open file descriptors. Using exit() may cause all stdio | ||
| # streams to be flushed twice and any temporary files may be unexpectedly |
| # shutdown time by changing it to the root directory. | ||
| os.chdir(WORKDIR) | ||
| # We probably don't want the file mode creation mask inherited from | ||
| # the parent, so we give the child complete control over permissions. |
| # POSIX.1 requires that every STOPPED process in an orphaned process | ||
| # group be sent a SIGHUP signal followed by a SIGCONT signal. Since the | ||
| # second child is not STOPPED though, we can safely forego ignoring the | ||
| # SIGHUP signal. In any case, there are no ill-effects if it is ignored. |
| # a controlling terminal. The second case isn't so easy to dismiss. | ||
| # The process group is orphaned when the first child terminates and | ||
| # POSIX.1 requires that every STOPPED process in an orphaned process | ||
| # group be sent a SIGHUP signal followed by a SIGCONT signal. Since the |
| # stopped, then SIGHUP and SIGCONT are sent to all members of the | ||
| # orphaned group." [2] | ||
| # | ||
| # The first case can be ignored since the child is guaranteed not to have |
| # two cases where SIGHUP is sent on the death of a process: | ||
| # | ||
| # 1) When the process that dies is the session leader of a session that | ||
| # is attached to a terminal device, SIGHUP is sent to all processes |
| # "However, as part of the session management system, there are exactly | ||
| # two cases where SIGHUP is sent on the death of a process: | ||
| # | ||
| # 1) When the process that dies is the session leader of a session that |
houndci-bot
reviewed
Oct 7, 2023
| raise Exception("%s [%d]" % (e.strerror, e.errno)) | ||
|
|
||
| if (pid == 0): # The first child. | ||
| # To become the session leader of this new session and the process group |
| return(0) | ||
| try: | ||
| # Fork a child process so the parent can exit. This returns control to | ||
| # the command-line or shell. It also guarantees that the child will not |
| os.dup2(0, 2) # standard error (2) | ||
|
|
||
| return(0) | ||
| try: |
There was a problem hiding this comment.
IndentationError: unexpected indent
unexpected indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous style fixes.