Add fully support to export traces with http #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 22, 2024
| elif nipap_config.has_option("tracing", "otlp_http_endpoint"): | ||
| nipap.tracing.init_tracing("nipap-www", nipap_config.get("tracing", "otlp_http_endpoint")) | ||
| else: | ||
| raise NipapConfigError("Tracing enabled but no OTLP endpoint configured") |
There was a problem hiding this comment.
line too long (89 > 79 characters)
nipap-www/nipapwww/__init__.py
Outdated
| if nipap_config.has_option("tracing", "otlp_grpc_endpoint"): | ||
| nipap.tracing.init_tracing("nipap-www", nipap_config.get("tracing", "otlp_grpc_endpoint"), True) | ||
| elif nipap_config.has_option("tracing", "otlp_http_endpoint"): | ||
| nipap.tracing.init_tracing("nipap-www", nipap_config.get("tracing", "otlp_http_endpoint")) |
There was a problem hiding this comment.
line too long (106 > 79 characters)
nipap-www/nipapwww/__init__.py
Outdated
| nipap.tracing.init_tracing("nipap-www", nipap_config.get("tracing", "otlp_grpc_endpoint")) | ||
|
|
||
| if nipap_config.has_option("tracing", "otlp_grpc_endpoint"): | ||
| nipap.tracing.init_tracing("nipap-www", nipap_config.get("tracing", "otlp_grpc_endpoint"), True) |
There was a problem hiding this comment.
line too long (112 > 79 characters)
| if use_grpc: | ||
| processor = BatchSpanProcessor(OTLPSpanExporter(endpoint=endpoint)) | ||
| else: | ||
| processor = BatchSpanProcessor(opentelemetry.exporter.otlp.proto.http.trace_exporter.OTLPSpanExporter(endpoint=endpoint)) |
There was a problem hiding this comment.
line too long (133 > 79 characters)
pynipap/tracing.py
Outdated
| @@ -22,7 +22,7 @@ | |||
| tracer = trace.get_tracer("pynipap") | |||
|
|
|||
|
|
|||
| def init_tracing(service_name, endpoint, use_grpc=True): | |||
| def init_tracing(service_name, endpoint, use_grpc=False): | |||
erikoqvist
force-pushed
the
add_fully_support_to_export_traces_with_http
branch
from
c4a93f4 to
4f3a8f5
Compare
houndci-bot
reviewed
Jan 22, 2024
| if nipap_config.has_option("tracing", "otlp_grpc_endpoint"): | ||
| nipap.tracing.init_tracing("nipap-www", nipap_config.get("tracing", "otlp_grpc_endpoint")) | ||
| elif nipap_config.has_option("tracing", "otlp_http_endpoint"): | ||
| nipap.tracing.init_tracing("nipap-www", nipap_config.get("tracing", "otlp_http_endpoint"), False) |
There was a problem hiding this comment.
line too long (113 > 79 characters)
| nipap.tracing.init_tracing("nipap-www", nipap_config.get("tracing", "otlp_grpc_endpoint")) | ||
|
|
||
| if nipap_config.has_option("tracing", "otlp_grpc_endpoint"): | ||
| nipap.tracing.init_tracing("nipap-www", nipap_config.get("tracing", "otlp_grpc_endpoint")) |
There was a problem hiding this comment.
line too long (106 > 79 characters)
erikoqvist
force-pushed
the
add_fully_support_to_export_traces_with_http
branch
from
4f3a8f5 to
a5264ca
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.