Fixed app not sending notification key on login #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebastian-Webster
deleted the
197-app-doesnt-resend-notification-key-if-it-has-been-sent-before
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old temp/sendnotificationkey API would store the notification key in the User document and the key would permanently stay there. The updated temp/sendnotificationkey API now stores the notification key in a RefreshToken document so when a device gets logged out, that device no longer gets any notifications from the account. Previously, SocialSquare would not resend the notification key after getting logged back in as the app already had it saved in AsyncStorage so it assumed it did not have to re-uplaod the key. Now whenever the user gets logged out, the notification key is deleted from AsyncStorage and the key is re-uploaded to the server on the next account login.