Classification PR Changes #2

swetha097 · 2022-10-18T09:03:05Z

No description provided.

* Zen DNN - Docker Updates * Zen DNN - Sample Updates * Codacy - Fix * Zen DNN - Cleanup * Zen DNN - single layer sample

* rocal updates for tf training * updates for rocal * tf updates and pytorch bug fixes * repo name change * Update README.md * dockerfile update * [rocAL] Fix rocAL Pybind build issue. * [rocAL] Remove unused function in pipeline. * [rocAL] Change rocAL pybind installation from setup.py to wheel. setup.py install is deprecated in python 3.9 * [rocAL] Make TF pets example dataset compatible with tf2. * [rocAL] Change getImageLabels() compatible with tf. * [rocAL] Add fix to pick wheel from dist installation folder. Remove the old installation files in conda environment. * [rocAL] Remove commented statement. Co-authored-by: shobana-mcw <[email protected]>

* turboJPEG version update * turboJPEG version update * turboJPEG version update * TurboJPEG version update * Update mivisionx-opencl-on-ubuntu20.dockerfile * Update zenDNN-HIP.dockerfile * Update level-5.dockerfile * Update level-5.dockerfile * Zen DNN Updates Sync Co-authored-by: Kiriti Gowda <[email protected]>

* custom node implementation files * fix build errors * custom extension changes for working implementation * add README and documentation * update readme * fix codacy issues and CPU flow * fix cadacy warning * Addressed review comments * minor change * fix formating

* fixes build issue * Update CMakeLists.txt

* batch size support for migraphx * changing to accept tensors of all batch sizes * creates file with results * bug fix * changes to singular test cases - mnist and resnet50 * readme updates * resolving PR comments * resolving PR comments * resolving PR comments * Readme update to reflect tot * formatting * fixing typo * readme update * readme update

…ogs (ROCm#930)

Add support to pass the resize scaling modes Add support to calculate the normalized crop

…ute-Libraries/MIVisionX into resize_scale_modes_PR

… param

…ute-Libraries/MIVisionX into PR_changes

sampath1117

@swetha097 Please address review comments

amd_openvx_extensions/amd_rpp/source/Resizetensor.cpp

rocAL/rocAL/include/api/rocal_api_data_loaders.h

rocAL/rocAL/include/decoders/image/decoder.h

rocAL/rocAL_pybind/rocal_pybind.cpp

rocAL/rocAL/source/decoders/image/fused_crop_decoder.cpp

amd_openvx_extensions/amd_rpp/source/Resizetensor.cpp

rocAL/rocAL/include/api/rocal_api_data_loaders.h

fiona-gladwin · 2022-10-18T12:52:46Z

rocAL/rocAL/source/decoders/image/fused_crop_decoder.cpp

+                            input_buffer,
+                            input_size,
+                            width,
+                            height,


Revert the trailing white space changes in this file

rocAL/rocAL/source/decoders/image/fused_crop_decoder.cpp

rocAL/rocAL/source/parameters/parameter_rali_crop.cpp

rocAL/rocAL/source/pipeline/image.cpp

rocAL/rocAL_pybind/amd/rocal/decoders.py

rocAL/rocAL/source/decoders/image/fused_crop_decoder.cpp

shobana-mcw

Some review comments are general. Check if there is other instances of the same.
In decoders.py file there are lots of changes introduced due to auto save coding guidelines set up in VS code. This will make it very difficult for them to review. Please revert back and add only necessary changes in any other editor if needed.

shobana-mcw · 2022-10-18T13:55:57Z

rocAL/rocAL/include/api/rocal_api_data_loaders.h

@@ -217,7 +217,7 @@ extern "C"  RocalImage  ROCAL_API_CALL rocalJpegCOCOFileSourcePartialSingleShard
 /// \return
 extern "C"  RocalImage  ROCAL_API_CALL rocalJpegCOCOFileSourceSingleShard(RocalContext context,
                                                                   const char* source_path,
-								   const char* json_path,


@swetha097 Revert this line change. It adds unnecessary file change.

shobana-mcw · 2022-10-20T09:18:04Z

rocAL/rocAL/include/api/rocal_api_data_loaders.h

@@ -167,7 +167,7 @@ extern "C"  RocalImage  ROCAL_API_CALL rocalJpegCOCOFileSourcePartial(RocalConte
                                                            bool is_output,
                                                            bool shuffle = false,
                                                            bool loop = false,
-                                                            RocalImageSizeEvaluationPolicy decode_size_policy = ROCAL_USE_MAX_SIZE,
+                                                            RocalImageSizeEvaluationPolicy decode_size_policy = ROCAL_USE_MAX_SIZE_RESTRICTED,


Can you check if this should be ROCAL_USE_MAX_SIZE_RESTRICTED or user given size restricted?

shobana-mcw · 2022-10-20T09:23:51Z

rocAL/rocAL/include/api/rocal_api_data_loaders.h

@@ -196,11 +196,13 @@ extern "C"  RocalImage  ROCAL_API_CALL rocalJpegCOCOFileSourcePartialSingleShard
                                                            unsigned shard_id,
                                                            unsigned shard_count,
                                                            bool is_output,
+                                                            std::vector<double>& area_factor, 
+                                                            std::vector<double>& aspect_ratio, 


Does this needs to be a vector or array of size 2?

rocAL/rocAL/include/decoders/image/fused_crop_decoder.h

shobana-mcw · 2022-10-20T09:30:09Z

rocAL/rocAL/include/decoders/image/fused_crop_decoder.h

+    std::mt19937 _rand_gen;
+    int64_t seed;
+    int64_t getseed() { return ParameterFactory::instance()->get_seed(); }
+    void generate_rngs(int64_t _seed, int64_t N) {


input param should not have _

rocAL/rocAL/source/decoders/image/fused_crop_decoder.cpp

rocAL/rocAL/source/parameters/parameter_rocal_crop.cpp

rocAL/rocAL/source/pipeline/master_graph.cpp

shobana-mcw · 2022-10-20T09:52:20Z

rocAL/rocAL_pybind/amd/rocal/decoders.py

-            "decode_size_policy": types.USER_GIVEN_SIZE,
-            "max_width": 2000,
-            "max_height": 2000}
-        image_decoder_output_image   = b.TF_ImageDecoder(Pipeline._current_pipeline._handle ,*(kwargs_pybind.values()))


Did we remove TF decoder from this call?

* Delete image_0.jpg * Delete image_1.jpg * Delete image_4.jpg * image update

* Readme updates - OpenVX Trademark Updates * Readme - Attribution Updates * Readme - Codacy Fix

* rocAL - rocAL PyBind .py files License * rocAL - Missing license * Tests - missing license fix * AMD OpenVX Extension - License fix * Apps & Samples - License Fix * Apps - Fix

Co-authored-by: Swetha B S <[email protected]>

* amd_media decoder add parameter for passing deviceid * minor cleanup * fix for review comments

* Update mivisionx-with-pytorch.dockerfile * Update mivisionx-with-tensorflow.dockerfile * Update level-5.dockerfile * Update mivisionx-on-ubuntu20.dockerfile * Update mivisionx-opencl-on-ubuntu20.dockerfile

* Update README.md * Update README.md * folder name change * Update README.md * Delete PYTHON_UNITTEST_TEST_FILE.sh * Delete rocAL/rocAL_pybind/example/new_api directory * Update README.md * Update README.md * Update README.md * Create README.md

…ute-Libraries/MIVisionX into PR_changes

constructor

kiritigowda and others added 30 commits August 25, 2022 10:36

Zen DNN - Docker & Tests (ROCm#924)

62c6f39

* Zen DNN - Docker Updates * Zen DNN - Sample Updates * Codacy - Fix * Zen DNN - Cleanup * Zen DNN - single layer sample

amd_migraphx - update readme for extension (ROCm#929)

3de90a3

amd_custom - fixes build issue (ROCm#935)

1151085

* fixes build issue * Update CMakeLists.txt

migraphx extension - update the readme(ROCm#936)

de55cae

OpenVX HIP backend - report correct number of CUs for gfx10+ in the l…

40112ef

…ogs (ROCm#930)

Add API to get reader config and decoder config

b65d884

Add API to obtain max and min aspect ratio from image source evaluator

a449779

Add scaling modes support

40b6ede

Add support to pass the resize scaling modes Add support to calculate the normalized crop

Minor change

63f141b

Remove crop parameters and related changes for resize

952037b

Fix segmentation fault

e25ac7b

Fix error with resize modes

82d9a08

MInor fix : update tensor ROI

99eeb5a

Merge branch 'develop' of https://github.com/GPUOpen-ProfessionalComp…

e6ad33c

…ute-Libraries/MIVisionX into resize_scale_modes_PR

Minor fix - center crop

0972161

Update the python API for resize with scaling modes and interpolation…

90937c1

… param

Minor changes

5230e66

Minor changes

212c3b0

Merge branch 'resize_scale_modes_PR' into fg/resize_scale_modes_PR

d8e93bc

Minor change

bf86a2e

Merge branch 'resize_scale_modes_PR' into fg/resize_scale_modes_PR

e6679ce

Remove center crop related changes

2667780

Remove redundant max size check

d36781c

Remove crop param from node resize

713bd15

Remove source evaluator

b3e071d

Minor fix

58e4981

swetha097 and others added 5 commits September 24, 2022 09:47

ResizeTensor addition

bb6ad60

Minor changes in PR

ce02195

ResizeTensor.cpp - Removing OpenCL backend support

ac65f69

Code Clean Up

b4acbeb

Merge branch 'develop' of https://github.com/GPUOpen-ProfessionalComp…

0a612c7

…ute-Libraries/MIVisionX into PR_changes

sampath1117 reviewed Oct 18, 2022

View reviewed changes

sampath1117 requested a review from fiona-gladwin October 18, 2022 11:49

fiona-gladwin requested changes Oct 18, 2022

View reviewed changes

Resolving internal PR comments

90bc9ff

sampath1117 requested a review from shobana-mcw October 18, 2022 14:09

fiona-gladwin reviewed Oct 19, 2022

View reviewed changes

rocAL/rocAL/source/decoders/image/fused_crop_decoder.cpp Show resolved Hide resolved

rocAL/rocAL/source/decoders/image/fused_crop_decoder.cpp Outdated Show resolved Hide resolved

shobana-mcw reviewed Oct 20, 2022

View reviewed changes

Swetha B S and others added 18 commits October 20, 2022 12:19

Resolve the internal review comments -2

b834ab3

Reesolve build error

bac136e

migraphx - palamida scan fix (ROCm#984)

3f5d519

* Delete image_0.jpg * Delete image_1.jpg * Delete image_4.jpg * image update

Readme updates - OpenVX Trademark Updates (ROCm#989)

36ffcd3

* Readme updates - OpenVX Trademark Updates * Readme - Attribution Updates * Readme - Codacy Fix

Media - License Issue Fix (ROCm#990)

87afc85

License Fix - rocAL (ROCm#992)

47419d1

* rocAL - rocAL PyBind .py files License * rocAL - Missing license * Tests - missing license fix * AMD OpenVX Extension - License fix * Apps & Samples - License Fix * Apps - Fix

runVisionTest - add a new test (ROCm#979)

525c99f

rocAL PyBind - Wheel Package Fix (ROCm#982)

ec83ab2

Co-authored-by: Swetha B S <[email protected]>

amd media - device support (ROCm#983)

84455cc

* amd_media decoder add parameter for passing deviceid * minor cleanup * fix for review comments

docker update - rpp version update (ROCm#986)

7ed51ac

* Update mivisionx-with-pytorch.dockerfile * Update mivisionx-with-tensorflow.dockerfile * Update level-5.dockerfile * Update mivisionx-on-ubuntu20.dockerfile * Update mivisionx-opencl-on-ubuntu20.dockerfile

Merge branch 'develop' of https://github.com/GPUOpen-ProfessionalComp…

f0d3ee9

…ute-Libraries/MIVisionX into PR_changes

Remove the is_centre_crop initilization as it is already set in

bd85af3

constructor

Changed to use std::min instead of if

1f2b730

Wrapping Long Lines of Code

a2cd7aa

Add the rng in the parameter_factory

6d17541

Add the sample idx argument

454c71f

Use different seeds for diff rngs

c7cf2dc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Classification PR Changes #2

Classification PR Changes #2

swetha097 commented Oct 18, 2022

sampath1117 left a comment

fiona-gladwin Oct 18, 2022

shobana-mcw left a comment

shobana-mcw Oct 18, 2022

shobana-mcw Oct 20, 2022

shobana-mcw Oct 20, 2022

shobana-mcw Oct 20, 2022

shobana-mcw Oct 20, 2022

Classification PR Changes #2

Are you sure you want to change the base?

Classification PR Changes #2

Conversation

swetha097 commented Oct 18, 2022

sampath1117 left a comment

Choose a reason for hiding this comment

fiona-gladwin Oct 18, 2022

Choose a reason for hiding this comment

shobana-mcw left a comment

Choose a reason for hiding this comment

shobana-mcw Oct 18, 2022

Choose a reason for hiding this comment

shobana-mcw Oct 20, 2022

Choose a reason for hiding this comment

shobana-mcw Oct 20, 2022

Choose a reason for hiding this comment

shobana-mcw Oct 20, 2022

Choose a reason for hiding this comment

shobana-mcw Oct 20, 2022

Choose a reason for hiding this comment