Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Love 11 #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support Love 11 #3

wants to merge 2 commits into from

Conversation

Mystro256
Copy link
Contributor

@Mystro256 Mystro256 commented Jun 11, 2018

Just keeping this awesome game alive by updating it to love 11.

Quick summary:

  • Color rgba values are now floats between 0-1, instead of integers between 0-255, so I wrote a wrapper for love.graphics.setColor for compatibility, and an adjustment for the two uses of getPixel
  • love.filesystem.exists is deprecated, so I wrote a compatibility wrapper for it's replacement
  • love.audio.newSource no longer assumes type, so I added stream for music, static for sfx. I think this is compatible with older versions but I didn't test with older than love 0.10.

Thanks!

@Stabyourself
Copy link
Owner

Hey, thanks for the PR

I don't think supporting more than 1 versions of löve is necessary. Of course supporting 11.1 over 0.10.2 would be preferable though.
I know I already accepted the PR that added 0.10+ support on top of 0.9 support, but I've changed my mind about this since then.

To that end, I don't think wrappers that convert 0-255 to 0-1 are a good idea. To properly support 11.1, the code should just use the 0-1 colors everywhere. Same goes for lf.exists (use lf.getInfo)

Thanks again for the PR though, if you're not up to changing it for "pure" 11.1 support, I'll take that up myself once löve.js is working well enough.

@Mystro256
Copy link
Contributor Author

Sound good, I made another commit, but it still wraps the color code. I'll look into it later if I have time.

@CoolCat467
Copy link

Time waits for no one. I am curious of the status of this project; It is a good game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants