Skip to content

Commit

Permalink
Merge pull request #5763: Add publisher to ActionAlias
Browse files Browse the repository at this point in the history
  • Loading branch information
cognifloyd authored Feb 7, 2023
2 parents 8d2304e + 76891f3 commit 70a8637
Show file tree
Hide file tree
Showing 6 changed files with 72 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ Added

* Added a joint index to solve the problem of slow mongo queries for scheduled executions. #5805

* Added publisher to ActionAlias to enable streaming ActionAlias create/update/delete events. #5763
Contributed by @ubaumann


3.8.0 - November 18, 2022
-------------------------
Expand Down
15 changes: 13 additions & 2 deletions st2common/st2common/persistence/actionalias.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,24 @@
# limitations under the License.

from __future__ import absolute_import
from st2common import transport
from st2common.models.db.actionalias import actionalias_access
from st2common.persistence import base as persistence
from st2common.persistence.base import Access

__all__ = [
"ActionAlias",
]

class ActionAlias(persistence.Access):

class ActionAlias(Access):
impl = actionalias_access

@classmethod
def _get_impl(cls):
return cls.impl

@classmethod
def _get_publisher(cls):
if not cls.publisher:
cls.publisher = transport.actionalias.ActionAliasPublisher()
return cls.publisher
8 changes: 7 additions & 1 deletion st2common/st2common/stream/listener.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@
from kombu.mixins import ConsumerMixin
from oslo_config import cfg

from st2common.models.api.action import LiveActionAPI
from st2common.models.api.action import LiveActionAPI, ActionAliasAPI
from st2common.models.api.execution import ActionExecutionAPI
from st2common.models.api.execution import ActionExecutionOutputAPI
from st2common.transport import utils as transport_utils
from st2common.transport.queues import STREAM_ACTIONALIAS_QUEUE
from st2common.transport.queues import STREAM_ANNOUNCEMENT_WORK_QUEUE
from st2common.transport.queues import STREAM_EXECUTION_ALL_WORK_QUEUE
from st2common.transport.queues import STREAM_EXECUTION_UPDATE_WORK_QUEUE
Expand Down Expand Up @@ -201,6 +202,11 @@ class StreamListener(BaseListener):

def get_consumers(self, consumer, channel):
return [
consumer(
queues=[STREAM_ACTIONALIAS_QUEUE],
accept=["pickle"],
callbacks=[self.processor(ActionAliasAPI)],
),
consumer(
queues=[STREAM_ANNOUNCEMENT_WORK_QUEUE],
accept=["pickle"],
Expand Down
41 changes: 41 additions & 0 deletions st2common/st2common/transport/actionalias.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# Copyright 2022 The StackStorm Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# All Exchanges and Queues related to liveaction.

from __future__ import absolute_import
from kombu import Exchange, Queue
from st2common.transport import publishers

__all__ = [
"ActionAliasPublisher",
"get_queue",
]

ACTIONALIAS_XCHG = Exchange("st2.actionalias", type="topic")


class ActionAliasPublisher(publishers.CUDPublisher):
def __init__(self):
super(ActionAliasPublisher, self).__init__(exchange=ACTIONALIAS_XCHG)


def get_queue(name=None, routing_key=None, exclusive=False, auto_delete=False):
return Queue(
name,
ACTIONALIAS_XCHG,
routing_key=routing_key,
exclusive=exclusive,
auto_delete=auto_delete,
)
2 changes: 2 additions & 0 deletions st2common/st2common/transport/bootstrap_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

from st2common import log as logging
from st2common.transport import utils as transport_utils
from st2common.transport.actionalias import ACTIONALIAS_XCHG
from st2common.transport.actionexecutionstate import ACTIONEXECUTIONSTATE_XCHG
from st2common.transport.announcement import ANNOUNCEMENT_XCHG
from st2common.transport.connection_retry_wrapper import ConnectionRetryWrapper
Expand Down Expand Up @@ -62,6 +63,7 @@

# List of exchanges which are pre-declared on service set up.
EXCHANGES = [
ACTIONALIAS_XCHG,
ACTIONEXECUTIONSTATE_XCHG,
ANNOUNCEMENT_XCHG,
EXECUTION_XCHG,
Expand Down
6 changes: 6 additions & 0 deletions st2common/st2common/transport/queues.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from kombu import Queue

from st2common.constants import action as action_constants
from st2common.transport import actionalias
from st2common.transport import actionexecutionstate
from st2common.transport import announcement
from st2common.transport import execution
Expand All @@ -42,6 +43,7 @@
"NOTIFIER_ACTIONUPDATE_WORK_QUEUE",
"RESULTSTRACKER_ACTIONSTATE_WORK_QUEUE",
"RULESENGINE_WORK_QUEUE",
"STREAM_ACTIONALIAS_QUEUE",
"STREAM_ANNOUNCEMENT_WORK_QUEUE",
"STREAM_EXECUTION_ALL_WORK_QUEUE",
"STREAM_EXECUTION_UPDATE_WORK_QUEUE",
Expand Down Expand Up @@ -94,6 +96,10 @@


# Used by the stream service
STREAM_ACTIONALIAS_QUEUE = actionalias.get_queue(
routing_key=publishers.ANY_RK, exclusive=True, auto_delete=True
)

STREAM_ANNOUNCEMENT_WORK_QUEUE = announcement.get_queue(
routing_key=publishers.ANY_RK, exclusive=True, auto_delete=True
)
Expand Down

0 comments on commit 70a8637

Please sign in to comment.