Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bionic/el7 and add el9 #187

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ version: 2
jobs:
build:
machine:
image: "ubuntu-2004:current"
image: "ubuntu-2204:2023.04.2"
working_directory: ~/StackStorm/st2chatops
parallelism: 4
parallelism: 3
shell: /bin/bash --login
environment:
DISTROS: bionic focal el7 el8
DISTROS: focal el8 el9
ST2_PACKAGES_REPO: https://github.com/StackStorm/st2-packages
ST2_TEST_ENVIRONMENT: https://github.com/StackStorm/st2-docker
DEPLOY_PACKAGES: 1
Expand All @@ -38,13 +38,12 @@ jobs:
docker-compose version
nodejs -v
jq --version
package_cloud version

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the removal of package_cloud version intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was getting an error with not found - so just trying to debug it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving PR into draft whilst I get the circleCI to pass...
This is the only repo that uses the package_cloud.sh that had that package_cloud version call - so just seeing what's going on...

- run:
name: Ensure Docker running
command: 'sudo docker info >/dev/null 2>&1 || sudo service docker start; '
- run:
name: Set up Ruby 2.0
command: rvm use ruby-2.0.0-p645 --default
# - run:
# name: Set up Ruby 2.0
# command: rvm use ruby-2.0.0-p645 --default
- run:
name: Get PackageCloud variables
command: |
Expand Down Expand Up @@ -122,7 +121,7 @@ jobs:
- image: circleci/ruby:2.7
working_directory: ~/packages
environment:
DISTROS: "bionic focal el7 el8"
DISTROS: "focal el8 el9"
steps:
- attach_workspace:
at: /home/circleci
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ Changed

Contributed by @lopf

* Added support for EL9. Removed support for EL7 and bionic. #187
Contributed by @amanda11

Removed
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
* Remove skills-validator from npm-shrinkwrap.json
Expand Down
20 changes: 4 additions & 16 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
# Packaging environments
bionic:
build: ./packagingenv/bionic
extends:
file: docker-compose.override.yml
service: suite

focal:
build: ./packagingenv/focal
extends:
Expand All @@ -17,19 +11,13 @@ el8:
file: docker-compose.override.yml
service: suite

el7:
build: ./packagingenv/centos7
el9:
build: ./packagingenv/rockylinux9
extends:
file: docker-compose.override.yml
service: suite

# Testing environments
bionic-test:
build: ./testingenv/bionic
extends:
file: docker-compose.override.yml
service: suite-test

focal-test:
build: ./testingenv/focal
extends:
Expand All @@ -42,8 +30,8 @@ el8-test:
file: docker-compose.override.yml
service: suite-test

el7-test:
build: ./testingenv/centos7
el9-test:
build: ./testingenv/rockylinux9
extends:
file: docker-compose.override.yml
service: suite-test
19 changes: 0 additions & 19 deletions packagingenv/bionic/Dockerfile

This file was deleted.

19 changes: 0 additions & 19 deletions packagingenv/bionic/docker-entrypoint.sh

This file was deleted.

12 changes: 0 additions & 12 deletions packagingenv/centos7/Dockerfile

This file was deleted.

21 changes: 21 additions & 0 deletions packagingenv/rockylinux9/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
FROM rockylinux:9

RUN yum -y install gcc-c++ make git libicu-devel rpmdevtools

# Add NodeSource repo
#RUN curl --silent --location https://rpm.nodesource.com/setup_18.x | bash -

# Install development tools
RUN yum -y module install nodejs:18
#
# Install python3 for gyp
RUN yum -y install python3

# Upgrade gyp to a python3 compatible version
RUN npm install -g node-gyp@latest

# Install development tools
RUN yum -y install nodejs

COPY docker-entrypoint.sh /entrypoint.sh
ENTRYPOINT [ "/entrypoint.sh" ]
15 changes: 0 additions & 15 deletions testingenv/bionic/Dockerfile

This file was deleted.

28 changes: 0 additions & 28 deletions testingenv/bionic/docker-entrypoint.sh

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM centos:7
FROM rockylinux:9

# Add NodeSource repo
RUN curl --silent --location https://rpm.nodesource.com/setup_10.x | bash -
Expand Down