-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update K8s to latest version #379
Conversation
- circleci/[email protected] - circleci/[email protected] - machine image ubuntu-2204:current - minikube v1.31.2 - latests kubernetes versions
- remove unsupported k8s - Update CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updates!
A couple of changes requested to address
.circleci/config.yml
Outdated
@@ -39,7 +39,7 @@ jobs: | |||
command: helm dependency update | |||
- run: | |||
name: Helm install stackstorm-ha chart | |||
command: helm install --timeout 10m0s --debug --wait --name-template stackstorm-ha . | |||
command: helm install --timeout 20m0s --debug --wait --name-template stackstorm-ha . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see any evidence that lifting install timeout helps.
Usually from the history of CI failures if deployment didn't complete in ~5mins, everything goes into a crash loop which is rarely recoverable without a manual intervention.
The usual reason behind the crash loop is one of the backend clusters didn't startup correctly like MongoDB, Redis or RabbitMQ.
But let's see if this helps.
Please use at least 15m
everywhere as bumping to 20mins
is too much!
command: helm install --timeout 20m0s --debug --wait --name-template stackstorm-ha . | |
command: helm install --timeout 15m0s --debug --wait --name-template stackstorm-ha . |
CHANGELOG.md
Outdated
@@ -1,6 +1,8 @@ | |||
# Changelog | |||
|
|||
## In Development | |||
* Bump to latest CircleCI orb versions (by @ZoeLeah) | |||
* Remove unsupported k8s Versions (by @ZoeLeah) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mention explicitly (eg. 26,27,28) the new K8s versions that are used for testing this Helm chart.
That would provide a better info for someone reading the Changelog and thinking if particular K8s version is supported or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the K8s refresh!
* Bump to latest CircleCI orb versions ([email protected] and [email protected] by @ZoeLeah) | ||
* Remove unsupported k8s Versions (1.24.x and 1.25.x by @ZoeLeah) | ||
* Update and add new K8s versions (1.28.3, 1.27.7 and 1.26.10 by @ZoeLeah) | ||
* Switch from ubuntu-2204:2022.10.2 to ubuntu-2204:current (by @ZoeLeah) | ||
* Update K3s to v1.28.3+k3s1 (by @ZoeLeah) | ||
* Increase helm install timeout to 15 minutes (by @ZoeLeah) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's too much of the changelog details for a single PR 😃 (balance is the key), but let's go with that
The following changes have been made: