Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #1

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Minor fixes #1

wants to merge 9 commits into from

Conversation

MetcalfeTom
Copy link

I ran into some issues when testing the code, so I thought to contribute my fixes 🤗

Changes:

Dataset generation

  • Fixed a bug with infeasible SCP solution
  • Added correct output folder to saving functions
  • Generated missing permutations array

Main optimization

  • Added wx dependency for mac environments to plot graphs
  • Pinned osqp to avoid this issue
  • Fixed the plotting of the control graph when not using both warmstarts
  • Moved the model to device after acceleration init (otherwise it can be placed somewhere else than the state vectors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MetcalfeTom