Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling of users #205

Merged
merged 16 commits into from
Jan 19, 2025
Merged

Allow disabling of users #205

merged 16 commits into from
Jan 19, 2025

Conversation

pauljohanneskraft
Copy link
Collaborator

@pauljohanneskraft pauljohanneskraft commented Jan 14, 2025

Allow disabling of users

♻️ Current situation & Problem

By calling the disableUser function, one can now disable user accounts that are blocked from all the functionality while the user's disabled property stays true. By calling enableUser, one can revert the change and re-enable a user account.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Contributor

@arkadiuszbachorski arkadiuszbachorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! 🚀

@arkadiuszbachorski
Copy link
Contributor

@pauljohanneskraft FYI I pushed Export functions

@pauljohanneskraft pauljohanneskraft marked this pull request as ready for review January 18, 2025 12:27
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing this so quickly @pauljohanneskraft! Thanks for the reviews @arkadiuszbachorski!

functions/src/tests/rules/users.test.ts Outdated Show resolved Hide resolved
@pauljohanneskraft pauljohanneskraft merged commit f6396bf into main Jan 19, 2025
6 checks passed
@pauljohanneskraft pauljohanneskraft deleted the disabled-users branch January 19, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants