Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display correct invitation code #87

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

pauljohanneskraft
Copy link
Contributor

Display correct invitation code

♻️ Current situation & Problem

Currently, the invitation id is displayed instead of the invitation code.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@pauljohanneskraft pauljohanneskraft self-assigned this Nov 4, 2024
@pauljohanneskraft pauljohanneskraft added the bug Something isn't working label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.93%. Comparing base (3fe8244) to head (9cc58e3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
modules/user/queries.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   30.93%   30.93%           
=======================================
  Files         186      186           
  Lines        6525     6525           
  Branches      333      333           
=======================================
  Hits         2018     2018           
  Misses       4421     4421           
  Partials       86       86           
Files with missing lines Coverage Δ
modules/user/queries.tsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe8244...9cc58e3. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @pauljohanneskraft!

I'll let @arkadiuszbachorski approve this & merge it. Might be good to just disable the textfield as we might not want anyone to edit their invitation code at the beginning.

@arkadiuszbachorski
Copy link
Collaborator

Thank you @pauljohanneskraft!

@arkadiuszbachorski arkadiuszbachorski merged commit d61edc0 into main Nov 5, 2024
25 of 26 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the display-correct-invitation-code branch November 5, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants