Fix location error propagation

LifeSpace/Location/LocationModule.swift

@@ -66,7 +66,7 @@ public class LocationModule: NSObject, CLLocationManagerDelegate, Module, Defaul
         self.manager.requestAlwaysAuthorization()
     }
 
-    public func fetchLocations() async {
+    public func fetchLocations() async throws {
         do {
             if let locations = try await standard?.fetchLocations() {
                 await storage.updateAllLocations(locations)
@@ -79,6 +79,7 @@ public class LocationModule: NSObject, CLLocationManagerDelegate, Module, Defaul
             }
         } catch {
             logger.error("Error fetching locations: \(error.localizedDescription)")
+            throw error
         }
     }
 
@@ -111,7 +112,7 @@ public class LocationModule: NSObject, CLLocationManagerDelegate, Module, Defaul
         /// Check if the date of the current point is a different day then the last saved point. If so,
         /// Refresh the locations array and save this point.
         if Date().startOfDay != lastSaved.date.startOfDay {
-            await fetchLocations()
+            try? await fetchLocations()
             return true
         }
 

LifeSpace/Map/LifeSpaceMapView.swift

@@ -14,12 +14,11 @@ import SwiftUI
 struct LifeSpaceMapView: View {
     @AppStorage(StorageKeys.trackingPreference) private var trackingOn = true
     @Environment(LocationModule.self) private var locationModule
-    @Environment(\.scenePhase) var scenePhase
 
     @State private var presentedContext: EventContext?
     @Binding private var presentingAccount: Bool
 
-    @State private var showingSurveyAlert = false
+    @State private var showingAlert = false
     @State private var alertMessage = ""
     @State private var showingSurvey = false
     @State private var optionsPanelOpen = true
@@ -60,13 +59,16 @@ struct LifeSpaceMapView: View {
                         Image(systemName: "arrow.clockwise")
                             .accessibilityLabel("REFRESHING_MAP")
                     }
+                    .disabled(isRefreshing)
                 }
             }
         }
-        .onChange(of: scenePhase) { _, newPhase in
-            if newPhase == .active {
-                refreshMap()
+        .alert("Error", isPresented: $showingAlert) {
+            Button("OK", role: .cancel) {
+                showingAlert = false
             }
+        } message: {
+            Text(alertMessage)
         }
         .onAppear {
             refreshMap()
@@ -111,9 +113,18 @@ struct LifeSpaceMapView: View {
     }
 
     private func refreshMap() {
+        guard !isRefreshing else {
+            return
+        }
+
         Task {
             isRefreshing = true
-            await locationModule.fetchLocations()
+            do {
+                try await locationModule.fetchLocations()
+            } catch {
+                alertMessage = error.localizedDescription
+                showingAlert = true
+            }
             isRefreshing = false
         }
     }