Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PLX (Pulse Oximeter) support #54

Merged
merged 4 commits into from
Nov 30, 2024
Merged

Add PLX (Pulse Oximeter) support #54

merged 4 commits into from
Nov 30, 2024

Conversation

lukaskollmer
Copy link
Member

Add PLX (Pulse Oximeter) support

♻️ Current situation & Problem

Bluetooth defines a Pulse Oximeter Service, which currently is not supported by SpeziBluetoothServices.
This PR adds support for this service.

⚙️ Release Notes

  • Added PulseOximeterService and related data types (e.g., PLXContinuousMeasurement).

📚 Documentation

The code is documented, similar to the other services that are already defined.

✅ Testing

The code is tested, similar to the other services that are already defined.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@lukaskollmer lukaskollmer requested a review from Supereg November 29, 2024 22:48
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 89.78102% with 28 lines in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (22e7dcf) to head (12243f5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...luetoothServices/Characteristics/PLXFeatures.swift 81.49% 10 Missing ⚠️
...ices/Characteristics/PLXSpotCheckMeasurement.swift 88.64% 10 Missing ⚠️
...ces/Characteristics/PLXContinuousMeasurement.swift 93.90% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   80.11%   80.98%   +0.87%     
==========================================
  Files         111      115       +4     
  Lines        6053     6327     +274     
==========================================
+ Hits         4849     5123     +274     
  Misses       1204     1204              
Files with missing lines Coverage Δ
...etoothServices/Services/PulseOximeterService.swift 100.00% <100.00%> (ø)
...luetoothServices/Services/WeightScaleService.swift 100.00% <ø> (ø)
...ces/Characteristics/PLXContinuousMeasurement.swift 93.90% <93.90%> (ø)
...luetoothServices/Characteristics/PLXFeatures.swift 81.49% <81.49%> (ø)
...ices/Characteristics/PLXSpotCheckMeasurement.swift 88.64% <88.64%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e7dcf...12243f5. Read the comment docs.

Copy link
Member

@Supereg Supereg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Awesome to set the list of supported Bluetooth Health services grow 🚀 I really only had comments regarding some minor documentations improvements. Everything else looks fantastic 👍

Generally, you might want to add these new types to the SpeziBluetoothServices.docc bundle and group them into fitting topics sections similar to the existing ones. What I like to do, is to Build Documentation locally in Xcode and look at which types are not grouped/structured yet. We currently have articles pages for Characteristics and Services to provide a good overview of all supported services and characteristics of SpeziBluetooth.

@lukaskollmer lukaskollmer merged commit e2600a2 into main Nov 30, 2024
9 checks passed
@lukaskollmer lukaskollmer deleted the lukas/plx branch November 30, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants