-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PLX (Pulse Oximeter) support #54
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 80.11% 80.98% +0.87%
==========================================
Files 111 115 +4
Lines 6053 6327 +274
==========================================
+ Hits 4849 5123 +274
Misses 1204 1204
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Awesome to set the list of supported Bluetooth Health services grow 🚀 I really only had comments regarding some minor documentations improvements. Everything else looks fantastic 👍
Generally, you might want to add these new types to the SpeziBluetoothServices.docc bundle and group them into fitting topics sections similar to the existing ones. What I like to do, is to Build Documentation
locally in Xcode and look at which types are not grouped/structured yet. We currently have articles pages for Characteristics
and Services
to provide a good overview of all supported services and characteristics of SpeziBluetooth.
Add PLX (Pulse Oximeter) support
♻️ Current situation & Problem
Bluetooth defines a Pulse Oximeter Service, which currently is not supported by SpeziBluetoothServices.
This PR adds support for this service.
⚙️ Release Notes
PulseOximeterService
and related data types (e.g.,PLXContinuousMeasurement
).📚 Documentation
The code is documented, similar to the other services that are already defined.
✅ Testing
The code is tested, similar to the other services that are already defined.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: