Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Swift 6 Language Mode #14

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Enable Swift 6 Language Mode #14

merged 4 commits into from
Nov 6, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Nov 4, 2024

Enable Swift 6 Language Mode

♻️ Current situation & Problem

This PR enables the Swift 6 Language Mode and fixes some concurrency issues.

⚙️ Release Notes

  • Enabled Swift 6 Language Mode

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg requested a review from PSchmiedmayer November 4, 2024 10:59
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.84%. Comparing base (03d82c2) to head (ea95583).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   54.79%   54.84%   +0.05%     
==========================================
  Files          21       21              
  Lines         982      983       +1     
==========================================
+ Hits          538      539       +1     
  Misses        444      444              
Files with missing lines Coverage Δ
...iMedication/Extensions/String+LocalizedError.swift 0.00% <ø> (ø)
...ziMedication/Extensions/UIDatePicker+SwiftUI.swift 0.00% <ø> (ø)
.../SpeziMedication/MedicationSettingsViewModel.swift 100.00% <ø> (ø)
Sources/SpeziMedication/Models/Weekdays.swift 3.80% <ø> (ø)
...ziMedication/ModifyMedication/EditMedication.swift 100.00% <100.00%> (ø)
...edication/ModifyMedication/ScheduleFrequency.swift 0.00% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d82c2...ea95583. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the updates @Supereg!

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Nov 5, 2024
@Supereg Supereg merged commit 8c160af into main Nov 6, 2024
8 checks passed
@Supereg Supereg deleted the feature/swift-6-support branch November 6, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants