fixed a divide by zero error when calculating Conductivity

StarCoreSE · Dec 6, 2024 · 967b228 · 967b228
1 parent 399164b
commit 967b228
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 20 deletions.
diff --git a/ThermalDynamics/Data/Scripts/Thermodynamics/Helper.cs b/ThermalDynamics/Data/Scripts/Thermodynamics/Helper.cs
@@ -39,8 +39,8 @@ public static Vector3I Unflatten(this Vector3I vector, long flatVector)
 
         public static int LargestFace(this Vector3I vector)
         {
-            int s1 = 0;
-            int s2 = 0;
+            int s1 = 1;
+            int s2 = 1;
             for (int i = 0; i < 3; i++)
             {
                 if (vector[i] >= s1) 
@@ -50,8 +50,6 @@ public static int LargestFace(this Vector3I vector)
                 }
             }
 
-
-
             return s1*s2;
         }
 

diff --git a/ThermalDynamics/Data/Scripts/Thermodynamics/Settings.cs b/ThermalDynamics/Data/Scripts/Thermodynamics/Settings.cs
@@ -89,7 +89,7 @@ public static Settings GetDefaults()
 				EnableEnvironment = true,
 				EnableSolarHeat = true,
 				EnableDamage = true,
-				Frequency = 4,
+				Frequency = 3,
 				SimulationSpeed = 1,
 				VacuumTemperature = 2.7f,
                 SolarEnergy = 500f,

diff --git a/ThermalDynamics/Data/Scripts/Thermodynamics/ThermalCell.cs b/ThermalDynamics/Data/Scripts/Thermodynamics/ThermalCell.cs
@@ -69,25 +69,11 @@ public ThermalCell(ThermalGrid g, IMySlimBlock b, ThermalCellDefinition def)
             ThermalMassInv = 1f / (Definition.SpecificHeat * Mass);
             Boltzmann = -1 * Definition.Emissivity * Tools.BoltzmannConstant;
 
-
-            //if (Mass < 500)
-            //{
-            //    Definition.Conductivity = 50;
-            //}
-            //else 
-            //{
-
-            //    float value = (Definition.SpecificHeat * Definition.SpecificHeat * Mass * Mass * Block.CubeGrid.GridSize) / (Area * ((Block.Max + 1) - Block.Min).LargestFace());
-
-
-            //}
-
             float value =  (Definition.SpecificHeat * Mass * Block.CubeGrid.GridSize) / (6 * Area * ((Block.Max + 1) - Block.Min).LargestFace());
-
             k = value * Definition.Conductivity;
             Definition.Conductivity = value;
 
-
+            //MyLog.Default.Info($"face: {(Block.Max + 1) - Block.Min} -- {((Block.Max + 1) - Block.Min).LargestFace()} -- {(6 * Area * ((Block.Max + 1) - Block.Min).LargestFace())} --- other: {(Definition.SpecificHeat * Mass * Block.CubeGrid.GridSize)}");
             UpdateHeat();
         }