-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed New Songs not loading and Downloading Issue 197 #200
base: master
Are you sure you want to change the base?
Conversation
-Fix URL path typo for New Songs list -Add User-Agent header for get requests from BeatSaver to fix downloading issue
I believe this fix should allow you to download new songs again in BeatDrop. To compile the source code into an executable you must install npm. Once installed, download my version of the repository, open cmd or command line and cd to the repo. Once you're in the repository run |
These fixes work, both for loading news songs and downloading songs! Thanks, nice work for your first PR! @Xonor13 @StarGazer1258 , you should consider merging this, because downloading songs doesn't work anymore with the current code. |
This works perfect once compiled. |
Can anyone help with compiling? |
Sure, do you encounter any problem? |
I also confirm, it's working for me as well. Thanks @Xonor13 ! Update: Not sure if this is allowed (Obviously not recommended, and I'd rather make this a v2.6.2.1, but yea...).... Here is a compiled version that I created on Windows 10: https://gofile.io/d/dtDgx7 |
-Fix URL path typo for New Songs, didn't realize it was already fixed #158
-Added User-Agent header to get requests from BeatSaver to fix downloading issue #197 #188 #187
This is my first Github contribution, so I am new to this whole pull request thing.